[#5873] feat(gvfs-fuse): add debug log for FuseApiHandle #5905
Conversation
unknowntpo
force-pushed
the
feat-fuse-debug-log
branch
2 times, most recently
from
9ae9ea0 to
3574bce
Compare
| inner: FuseApiHandle::new(fs, context), | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
These functions that are not part of the Filesystem trait do not need to add debug logs.
| } | ||
|
|
||
| impl<T: RawFileSystem> Filesystem for FuseApiHandleDebug<T> { | ||
| async fn init(&self, req: Request) -> fuse3::Result<ReplyInit> { |
There was a problem hiding this comment.
We need to implement all interfaces of the Filesystem. If they are not implemented yet, an error log should be recorded.
| async fn init(&self, req: Request) -> fuse3::Result<ReplyInit> { | ||
| debug!("init: req: {:?}", req); | ||
| let result = self.inner.init(req).await; | ||
| debug!("init result: {:?}", result); |
There was a problem hiding this comment.
This is an asynchronous multithreaded model. Logs from two print statements within a single function may be interleaved with logs from other interfaces. It is necessary to identify them in the logs.
| async fn lookup(&self, req: Request, parent: Inode, name: &OsStr) -> fuse3::Result<ReplyEntry> { | ||
| debug!("lookup: req: {:?}, parent: {:?}, name: {:?}", req, parent, name); | ||
| let result = self.inner.lookup(req, parent, name).await; | ||
| debug!("lookup result: {:?}", result); |
There was a problem hiding this comment.
If an error is returned, it should be logged using error!.
| atime: Option<Timestamp>, | ||
| mtime: Option<Timestamp>, | ||
| ) -> Result<FileStat, Errno> { | ||
| debug!("get_modified_file_stat: file_id: {}, size: {:?}, atime: {:?}, mtime: {:?}", file_id, size, atime, mtime); |
There was a problem hiding this comment.
It’s best to convert file_id to a file path to improve readability, for example, "/a/b.txt(2342)". Other variables should follow a similar approach.
|
Please refer to other PRs for the format of PR titles and descriptions. |
unknowntpo
changed the title
unknowntpo
force-pushed
the
feat-fuse-debug-log
branch
from
d1bfdba to
425c490
Compare
What changes were proposed in this pull request?
Implement
FuseApiHandleDebugso we can log all input arguments and return values ofFuseApiHandle.Fix: #5873
Does this PR introduce any user-facing change?
No.
How was this patch tested?
manually.