-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5985] improvement(CLI): Fix role command that supports handling multiple values #5988
Conversation
…ng multiple values Fix role command that supports handling multiple values, CLI can create and delete multiple roles simultaneously.
…ng multiple values Add test case.
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteRole.java
Outdated
Show resolved
Hide resolved
clients/cli/src/test/java/org/apache/gravitino/cli/TestRoleCommands.java
Outdated
Show resolved
Hide resolved
clients/cli/src/test/java/org/apache/gravitino/cli/TestRoleCommands.java
Show resolved
Hide resolved
@Abyss-lord Please fix the conflicting file. Thanks. |
@justinmclean Should |
Probably not. You might want to grant multiple permissions at once (which is supported), but it's perhaps not that common to grant or revoke to/from multiple roles at once. |
thank you Justin, only the |
…ng multiple values Fix some issue due to reviewer's opinion.
Hi @justinmclean @xunliu , I’ve finished updating the code. Please take a look at the PR again when you have time. |
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
What changes were proposed in this pull request?
In
GravitinoOptions
, the role option supports multiple values, but the handleRoleCommand implementation currently only processes a single role value. CLI should support create and delete multiple roles simultaneously.Why are the changes needed?
Fix: #5985
Does this PR introduce any user-facing change?
NO
How was this patch tested?
local test + UT