[#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � clients/filesystem-fuse/src/main.rs � Conflicts: � clients/filesystem-fuse/src/filesystem.rs � clients/filesystem-fuse/src/main.rs
FANNG1
reviewed
Jan 1, 2025
| @@ -30,32 +30,41 @@ use std::path::{Path, PathBuf}; | |||
| pub(crate) struct GravitinoFilesetFileSystem { | |||
| physical_fs: Box<dyn PathFileSystem>, | |||
| client: GravitinoClient, | |||
| fileset_location: PathBuf, | |||
| // target_path is a absolute path in the physical filesystem that is associated with the fileset. | |||
There was a problem hiding this comment.
Need a absolute path without bucket
| @@ -30,32 +30,41 @@ use std::path::{Path, PathBuf}; | |||
| pub(crate) struct GravitinoFilesetFileSystem { | |||
| physical_fs: Box<dyn PathFileSystem>, | |||
| client: GravitinoClient, | |||
| fileset_location: PathBuf, | |||
| // target_path is a absolute path in the physical filesystem that is associated with the fileset. | |||
There was a problem hiding this comment.
rename fileset_location to target_path seems confusing
There was a problem hiding this comment.
For example, the fileset location is s3://bucket/path/to/file, and the target path is /path/to/file.
So, using 'fileset_location' is ambiguous
There was a problem hiding this comment.
I know, but by using target_path, I couldn't figure out the relationship of target_path to fileset location, which confused me.
FANNG1
reviewed
Jan 3, 2025
| @@ -132,6 +134,13 @@ impl<T: PathFileSystem> DefaultRawFileSystem<T> { | |||
| let mut file_manager = self.file_entry_manager.write().await; | |||
| file_manager.insert(parent_file_id, file_id, path); | |||
| } | |||
|
|
|||
| fn meta_file_stat(&self) -> FileStat { | |||
There was a problem hiding this comment.
get_meta_file_stat or new_meta_file_stat ?
| @@ -168,15 +184,22 @@ impl<T: PathFileSystem> RawFileSystem for DefaultRawFileSystem<T> { | |||
| } | |||
|
|
|||
| async fn stat(&self, file_id: u64) -> Result<FileStat> { | |||
| if file_id == FS_META_FILE_ID { | |||
There was a problem hiding this comment.
could you use a function like is_meta_file(file_id). is_meta_file(parent_file_id, file_name) for below logics
| @@ -35,6 +35,9 @@ pub(crate) const ROOT_DIR_FILE_ID: u64 = 1; | |||
| pub(crate) const ROOT_DIR_NAME: &str = ""; | |||
| pub(crate) const ROOT_DIR_PATH: &str = "/"; | |||
| pub(crate) const INITIAL_FILE_ID: u64 = 10000; | |||
| pub(crate) const FS_META_FILE_PATH: &str = "/.gvfs_meta"; | |||
| pub(crate) const FS_META_FILE_NAME: &str = ".gvfs_meta"; | |||
There was a problem hiding this comment.
what's the usage of meta data file?
There was a problem hiding this comment.
use it for the other process check the gvfs-fuse is mounted
| let bucket = extract_bucket(&fileset.storage_location)?; | ||
| opendal_config.insert("bucket".to_string(), bucket); | ||
|
|
||
| let endpoint = catalog.properties.get("s3-endpoint"); |
There was a problem hiding this comment.
s3-endpoint may be empty for fileset, cc @yuqi1129
There was a problem hiding this comment.
please try get s3-region first, maybe we could use a new func like get_s3_region()
|
LGTM except minor comments |
FANNG1
approved these changes
Jan 3, 2025
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 3, 2025
…em operation in gvfs fuse (apache#6013) ### What changes were proposed in this pull request? Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal ### Why are the changes needed? Fix: apache#6012 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually test --------- Co-authored-by: Qiming Teng <[email protected]>
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 3, 2025
…em operation in gvfs fuse (apache#6013) ### What changes were proposed in this pull request? Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal ### Why are the changes needed? Fix: apache#6012 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually test --------- Co-authored-by: Qiming Teng <[email protected]>
jerryshao
pushed a commit
that referenced
this pull request
Jan 3, 2025
…ration in gvfs fuse (#6013) ### What changes were proposed in this pull request? Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal ### Why are the changes needed? Fix: #6012 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually test --------- Co-authored-by: Qiming Teng <[email protected]>
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 4, 2025
…em operation in gvfs fuse (apache#6013) ### What changes were proposed in this pull request? Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal ### Why are the changes needed? Fix: apache#6012 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually test --------- Co-authored-by: Qiming Teng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal
Why are the changes needed?
Fix: #6012
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually test