-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5965] subtask(web): ML model support for web UI #6025
Conversation
Can you please also add the web UI doc in this PR. |
Sure, I updated the commit. |
The CI is failed, can you please fix the CI, thanks. |
docs/assets/webui/link-version.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this image cannot be displayed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, and the image is displaying normally on my end.
docs/assets/webui/list-columns.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this image correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/assets/webui/list-columns.png is actually correct. Need to click view file to see full image.
docs/webui.md
Outdated
3. **Provider**(**_required_**): | ||
1. Type `relational` - `hive`/`iceberg`/`mysql`/`postgresql`/`doris`/`paimon`/`hudi`/`oceanbase` | ||
2. Type `fileset` - `hadoop` | ||
3. Type `messaging` - `kafka` | ||
4. Type `model` have no provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...has no provider"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it has no provider, then provider is also not required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for type relational /fileset/messaging
.
web/web/src/app/metalakes/metalake/rightContent/LinkVersionDialog.js
Outdated
Show resolved
Hide resolved
web/web/src/app/metalakes/metalake/rightContent/LinkVersionDialog.js
Outdated
Show resolved
Hide resolved
} | ||
}) | ||
.catch(err => { | ||
console.error('valid error', err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valid error
seems a bit unclear or weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for debugging purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
trigger('aliases') | ||
}} | ||
label={`Aliase ${index + 1}`} | ||
error={!!errors.aliases?.[index]?.name || !!errors.aliases?.message} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using !!
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error field accepts a boolean value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks.
web/web/src/app/metalakes/metalake/rightContent/RegisterModelDialog.js
Outdated
Show resolved
Hide resolved
web/web/src/app/metalakes/metalake/rightContent/RegisterModelDialog.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for explaining and improving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LauraXia123, |
sorry, I missed it. |
What changes were proposed in this pull request?
create catalog
create schema
register/view/drop/list model
link/view/drop/list versions
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: #5817
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually