Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5950] feat(catalog-model): Add integration tests for model API #6051

Merged
merged 8 commits into from
Jan 2, 2025

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds the integration tests for model API to make sure it works as expected.

Why are the changes needed?

To have an end to end test.

Fix: #5950

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add ITs.

@jerryshao jerryshao self-assigned this Dec 31, 2024
@tengqm
Copy link
Contributor

tengqm commented Dec 31, 2024

/lgtm

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit ece06fa into apache:main Jan 2, 2025
26 checks passed
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this pull request Jan 3, 2025
apache#6051)

### What changes were proposed in this pull request?

This PR adds the integration tests for model API to make sure it works
as expected.

### Why are the changes needed?

To have an end to end test.

Fix: apache#5950 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Add ITs.

---------

Co-authored-by: Qi Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]Add integration test for both Python and Java APIs
4 participants