[#5963] feat(client): added delete cli command model #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VigneshSK17
changed the title
|
@justinmclean When you find the time, could you please review this? Thanks. |
justinmclean
reviewed
Jan 5, 2025
justinmclean
reviewed
Jan 5, 2025
justinmclean
reviewed
Jan 5, 2025
| { | ||
| boolean force = line.hasOption(GravitinoOptions.FORCE); | ||
| newDeleteModel(url, ignore, force, metalake, catalog, schema, model).handle(); | ||
| break; |
There was a problem hiding this comment.
very minor, but keep break as last line
There was a problem hiding this comment.
I did update to fix this, but I'm curious if you mean that break should be the last line of a case clause, even if there's braces around the code inside the case clause?
|
Made the slight changes to the docs as mentioned above. |
justinmclean
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The delete command is one of the commands suggested by @justinmclean as part of adding Model entity support for the CLI.
Why are the changes needed?
To add delete functionality for a Model using the CLI
Improvement: #5963 (NOTE: Create command is redundant with addition of Register command)
Does this PR introduce any user-facing change?
Yes.
The delete command for a model was added.
How was this patch tested?
Unit tests were added for Model CLI support and ran successfully for the delete command, along with CI tests in forked repository