Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6222]feat(tag): Add tag support for model #6228

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds the tag support for model metadata.

Why are the changes needed?

This is to complement the tag support for model metadata.

Fix: #6222

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add ITs in test.

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @jerqi @yuqi1129 Do you want to review it?

@jerryshao jerryshao merged commit 4c5e9db into apache:main Jan 22, 2025
28 checks passed
jerqi pushed a commit that referenced this pull request Jan 23, 2025
### What changes were proposed in this pull request?

This PR adds the tag support for model metadata.

### Why are the changes needed?

This is to complement the tag support for model metadata.

Fix: #6222 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Add ITs in test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]Add tag support for model
3 participants