Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6239] fix: No need for toString() on string (CLI) #6247

Merged
merged 1 commit into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ public void handle() {

String all = Joiner.on(System.lineSeparator()).join(metalakeDetails);

System.out.print(all.toString());
System.out.print(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ public void handle() {

String all = roles.isEmpty() ? "The group has no roles." : String.join(",", roles);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ public void handle() {

String all = tags.length == 0 ? "No tags exist." : String.join(",", tags);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ public void handle() {
+ System.lineSeparator());
}

System.out.print(all.toString());
System.out.print(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,6 @@ public void handle() {

String all = String.join(",", tags);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,6 @@ public void handle() {

String all = filesets.length == 0 ? "No filesets exist." : Joiner.on(",").join(filesets);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ public void handle() {

String all = groups.length == 0 ? "No groups exist." : String.join(",", groups);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ public void printProperties(Map<String, String> properties) {
all.append(property.getKey() + "," + property.getValue() + System.lineSeparator());
}

System.out.print(all.toString());
System.out.print(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ public void handle() {

String all = roles.length == 0 ? "No roles exist." : String.join(",", roles);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ public void handle() {

String all = schemas.length == 0 ? "No schemas exist." : Joiner.on(",").join(schemas);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ public void handle() {
? "No tables exist."
: Joiner.on(System.lineSeparator()).join(tableNames);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ public void handle() {
exitWithError(exp.getMessage());
}

String all = String.join(",", users);
String all = users.length == 0 ? "No users exist." : String.join(",", users);

System.out.println(all.toString());
System.out.println(all);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

package org.apache.gravitino.cli.commands;

import com.google.common.base.Joiner;
import org.apache.gravitino.Catalog;
import org.apache.gravitino.NameIdentifier;
import org.apache.gravitino.Schema;
Expand All @@ -33,7 +32,6 @@
import org.apache.gravitino.rel.Table;

public class UntagEntity extends Command {
public static final Joiner COMMA_JOINER = Joiner.on(", ").skipNulls();
protected final String metalake;
protected final FullName name;
protected final String[] tags;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ public void handle() {

String all = roles.isEmpty() ? "The user has no roles." : String.join(",", roles);

System.out.println(all.toString());
System.out.println(all);
}
}
Loading