[#6361] feat(paimon):Support specifying primary keys during create paimon table by flink #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate paimon table by flink
…ate paimon table by flink
…ate paimon table by flink
FANNG1
reviewed
Jan 24, 2025
...flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 24, 2025
tengqm
reviewed
Jan 26, 2025
| if (primaryColumns == null) { | ||
| return new Index[0]; | ||
| } | ||
| String[][] primaryFiled = |
There was a problem hiding this comment.
Suggested change
| String[][] primaryFiled = | |
| String[][] primaryField = |
| @@ -521,6 +552,11 @@ protected CatalogBaseTable toFlinkTable(Table table) { | |||
| .column(column.name(), column.nullable() ? flinkType.nullable() : flinkType.notNull()) | |||
| .withComment(column.comment()); | |||
| } | |||
| Index[] indices = table.index(); | |||
| if (indices != null && indices.length == 1) { | |||
There was a problem hiding this comment.
So .... this means the primary key always has a SINGLE column, right?
There was a problem hiding this comment.
No. this means that only one primary key is supported. The Index object also stores field information and there can be multiple fields.
FANNG1
reviewed
Jan 26, 2025
...paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2025
...-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2025
...-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2025
...-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2025
...flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2025
...-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 26, 2025
...paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 27, 2025
| try { | ||
| catalog().asTableCatalog().createTable(identifier, columns, comment, properties, partitions); | ||
|
|
||
| Index[] indices = getGrivatinoIndeics(resolvedTable); |
| if (primaryKeyList.isEmpty()) { | ||
| return; | ||
| } | ||
| Preconditions.checkArgument( |
There was a problem hiding this comment.
could you add the check for the size of filednames too?
| Map<String, String> flinkTableProperties = | ||
| propertiesConverter.toFlinkTableProperties(table.properties()); | ||
| List<String> partitionKeys = partitionConverter.toFlinkPartitionKeys(table.partitioning()); | ||
| return CatalogTable.of(builder.build(), table.comment(), partitionKeys, flinkTableProperties); | ||
| } | ||
|
|
||
| private static void handleFlinkPrimaryKey( |
There was a problem hiding this comment.
could you use String getFlinkPrimaryKey(Table table) to return the primary field name, builder could use field name to build primary key.
|
LGTM except minior comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support specifying primary keys during create paimon table by flink
Why are the changes needed?
Fix: #6361
Does this PR introduce any user-facing change?
None
How was this patch tested?
Add testCreateTableWithPrimaryKey case in org.apache.gravitino.flink.connector.integration.test.FlinkCommonIT