Skip to content

GROOVY-11606: Lazy findAll, collect, collectMany (alternative proposa… #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

paulk-asert
Copy link
Contributor

…l - breaking changes but results in cleaner API)

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 83.83838% with 32 lines in your changes missing coverage. Please review.

Project coverage is 68.9544%. Comparing base (2d197ce) to head (17f84e2).

Files with missing lines Patch % Lines
.../codehaus/groovy/runtime/DefaultGroovyMethods.java 83.5897% 20 Missing and 12 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2184        +/-   ##
==================================================
+ Coverage     68.9473%   68.9544%   +0.0071%     
- Complexity      29550      29555         +5     
==================================================
  Files            1423       1423                
  Lines          113900     114055       +155     
  Branches        19752      19771        +19     
==================================================
+ Hits            78531      78646       +115     
- Misses          28771      28796        +25     
- Partials         6598       6613        +15     
Files with missing lines Coverage Δ
...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java 89.5833% <100.0000%> (ø)
.../codehaus/groovy/runtime/DefaultGroovyMethods.java 74.4818% <83.5897%> (+0.3533%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulk-asert paulk-asert force-pushed the groovy11606b branch 3 times, most recently from ecba06e to e4e9323 Compare April 11, 2025 09:46
@paulk-asert paulk-asert marked this pull request as draft April 14, 2025 00:33
@paulk-asert
Copy link
Contributor Author

paulk-asert commented Apr 14, 2025

This and PR #2182 are meant to be alternatives to examine

…l - breaking changes but results in cleaner API)
@daniellansun
Copy link
Contributor

This and PR #2182 are meant to be alternatives to examine

LGTM

@paulk-asert
Copy link
Contributor Author

This PR had breaking changes. Most feedback has indicated the preference for offering both eager and lazy versions of certain iterator methods and hence avoid the backwards compatibility issues. I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants