Skip to content

Run tests on Java 25-ea with toolchain #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 17, 2025

No description provided.

@Goooler Goooler marked this pull request as draft August 17, 2025 13:30
@Goooler Goooler force-pushed the g/20250817/set-up-java-ea branch from f57d6d7 to a2a30d0 Compare August 17, 2025 13:41
@Goooler Goooler force-pushed the g/20250817/set-up-java-ea branch from a2a30d0 to 9ebd891 Compare August 17, 2025 13:48
@Goooler Goooler changed the title Replace setup-java-25-ea steps with actions/setup-java Run tests on Java 25-ea with toolchain Aug 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@ccb1263). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #2276   +/-   ##
===========================================
  Coverage          ?   67.4614%           
  Complexity        ?      29280           
===========================================
  Files             ?       1381           
  Lines             ?     115727           
  Branches          ?      20178           
===========================================
  Hits              ?      78071           
  Misses            ?      31251           
  Partials          ?       6405           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

println "Using ${executable} to run tests"
if (rootProject.hasProperty('test.java.ea')) {
javaLauncher = javaToolchains.launcherFor {
languageVersion = JavaLanguageVersion.of(25)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to pass the java version via arguments to achieve better flexibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can. That's a good idea!

@daniellansun
Copy link
Contributor

Does toolchain support more ea versions present in the following link, e.g. JDK 26-ea?

https://jdk.java.net/

@Goooler
Copy link
Member Author

Goooler commented Aug 17, 2025

Yeah, the EA supports are due to https://github.com/foojayio/discoapi.

@Goooler
Copy link
Member Author

Goooler commented Aug 17, 2025

Blocker: gradle/foojay-toolchains#109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants