-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Run tests on Java 25-ea with toolchain #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f57d6d7
to
a2a30d0
Compare
a2a30d0
to
9ebd891
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2276 +/- ##
===========================================
Coverage ? 67.4614%
Complexity ? 29280
===========================================
Files ? 1381
Lines ? 115727
Branches ? 20178
===========================================
Hits ? 78071
Misses ? 31251
Partials ? 6405 🚀 New features to boost your workflow:
|
println "Using ${executable} to run tests" | ||
if (rootProject.hasProperty('test.java.ea')) { | ||
javaLauncher = javaToolchains.launcherFor { | ||
languageVersion = JavaLanguageVersion.of(25) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to pass the java version via arguments to achieve better flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can. That's a good idea!
Does toolchain support more ea versions present in the following link, e.g. JDK 26-ea? |
Yeah, the EA supports are due to https://github.com/foojayio/discoapi. |
Blocker: gradle/foojay-toolchains#109. |
No description provided.