Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19075. add shaded jersey jar hadoop-shaded-jersey. #33

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

slfan1989
Copy link
Contributor

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

JIRA: HADOOP-19075. add shaded jersey jar hadoop-shaded-jersey.

We need to address the issue of upgrading Jersey, replacing Jersey 1.x with Jersey 2.x. Jersey 2 and Jersey 1 are completely different, with many differences, and the same project cannot simultaneously introduce Jersey 2 and Jersey 1.
In order to allow the project to reference both Jersey 2 and Jersey 1 simultaneously, facilitating the step-by-step module upgrade process, I plan to introduce Jersey 2 into hadoop-thirdparty.

pom.xml Outdated
@@ -126,6 +132,7 @@
<module>hadoop-shaded-protobuf_3_21</module>
<module>hadoop-shaded-guava</module>
<module>hadoop-shaded-avro_1_11</module>
<module>hadoop-shaded-jersery</module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - should be jersey - maybe you it should be jersey_2 to match avro and protobuf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still being improved, and I'm currently attempting to replace Jersey1 with Jersey2 locally. There has been some progress; I've completed modifications to several unit tests in the nodemanager module, which are as expected. However, completing the entire process will take a long time as there are many conflicts, not just with javax.ws.rs. It's indeed a very challenging process.

cc: @steveloughran @ayushtkn

@pjfanning
Copy link
Contributor

pjfanning commented Feb 15, 2024

Would it make sense at this stage to skip Jersey2 and go to Jersey3 instead?

https://eclipse-ee4j.github.io/jersey/download.html

Jersey 2 will stop being supported at some point and Jersey 3 will be maintained for longer.

I am no expert but I think Jersey 3.1 is not very different from Jersey 2 but uses jakarta-rs instead of jax-rs dependency. The Jakarta libs are basically the JAX libs but with the package changed from javax to jakarta to avoid licensing issues with the Java name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants