HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526

PDavid · 2024-12-10T11:06:39Z

This is the backport of #6490 for branch-2.6.

As these are not present anymore in v4.

Reason: to make sure that they are the same size (this under thrift was smaller).

This is the latest non-vulnerable version.

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

to make the UI coloring look similar to what we had before.

to make sure the current active navbar link is highlighted appropriately.

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

Make sure background color is visible in tables (Tasks) where alert class is used.

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

Apache-HBase · 2024-12-11T15:11:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 8s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 33s		branch-2.6 passed
+1 💚	compile	7m 50s		branch-2.6 passed
+1 💚	checkstyle	1m 20s		branch-2.6 passed
+1 💚	spotbugs	13m 43s		branch-2.6 passed
+1 💚	spotless	1m 2s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 54s		the patch passed
+1 💚	compile	7m 14s		the patch passed
+1 💚	javac	7m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 8s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	13m 57s		the patch passed
+1 💚	hadoopcheck	22m 36s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		85m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6526
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs
uname	Linux 11bd622fcf96 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59553ca`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	180 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T22:28:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 9s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 21s		branch-2.6 passed
+1 💚	compile	2m 42s		branch-2.6 passed
+1 💚	javadoc	3m 46s		branch-2.6 passed
+1 💚	shadedjars	7m 56s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 35s		the patch passed
+1 💚	compile	2m 45s		the patch passed
+1 💚	javac	2m 45s		the patch passed
+1 💚	javadoc	3m 48s		the patch passed
+1 💚	shadedjars	7m 12s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	477m 39s	/patch-unit-root.txt	root in the patch failed.
		522m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6526
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux faadc1ccfd33 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59553ca`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/testReport/
Max. process+thread count	5266 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T22:37:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 5s		branch-2.6 passed
+1 💚	compile	3m 29s		branch-2.6 passed
+1 💚	javadoc	4m 4s		branch-2.6 passed
+1 💚	shadedjars	6m 41s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s		the patch passed
+1 💚	compile	2m 40s		the patch passed
+1 💚	javac	2m 40s		the patch passed
+1 💚	javadoc	3m 28s		the patch passed
+1 💚	shadedjars	6m 54s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	486m 52s	/patch-unit-root.txt	root in the patch failed.
		532m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6526
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a29a527b125d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59553ca`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/testReport/
Max. process+thread count	5206 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T23:38:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s		branch-2.6 passed
+1 💚	compile	2m 17s		branch-2.6 passed
+1 💚	javadoc	3m 16s		branch-2.6 passed
+1 💚	shadedjars	5m 33s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 41s		the patch passed
+1 💚	compile	1m 52s		the patch passed
+1 💚	javac	1m 52s		the patch passed
+1 💚	javadoc	3m 12s		the patch passed
+1 💚	shadedjars	5m 27s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	557m 23s	/patch-unit-root.txt	root in the patch failed.
		592m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6526
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c05f03a17d6b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59553ca`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/testReport/
Max. process+thread count	5026 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6526/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid added 18 commits December 10, 2024 11:06

HBASE-28832 Removed bootstrap-theme.min.css and Glyphicons icon font

915f23f

As these are not present anymore in v4.

HBASE-28832 Upgrade to Bootstrap 4

332c637

HBASE-28832 Migrated Log Level forms

3c8a271

HBASE-28832 Migrated REST web UI pages

ce3a561

HBASE-28832 Migrated canary status page navbar

87d773e

HBASE-28832 Migrated Thrift UI pages

aab8974

HBASE-28832 Replaced hbase_logo_small.png with hbase-server one

ead99b5

Reason: to make sure that they are the same size (this under thrift was smaller).

HBASE-28832 Upgraded Bootstrap to 5.3.3

7900881

This is the latest non-vulnerable version.

HBASE-28832 Migrated navbars

4844bdc

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

HBASE-28832 Migrated data attributes

35025aa

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

HBASE-28832 Migrated inline forms - Log levels, table.jsp

156fa16

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

HBASE-28832 Fixed checkstyle warnings

5c2a80d

HBASE-28832 Preserve original HBase UI colors

1d3a8a9

to make the UI coloring look similar to what we had before.

HBASE-28832 Restore active navbar link background-color

bea604e

to make sure the current active navbar link is highlighted appropriately.

HBASE-28832 Migrated pagination in jqSpager.js

cc8f138

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

HBASE-28832 Avoid double bottom borders with tables in tab contents

c728dc5

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

HBASE-28832 Fixed Tasks table row background colors were not visible

b23eb7c

Make sure background color is visible in tables (Tasks) where alert class is used.

HBASE-28832 Added missing favicon for Thrift UI

d286744

This comment has been minimized.

Sign in to view

PDavid marked this pull request as ready for review December 10, 2024 14:17

PDavid mentioned this pull request Dec 10, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6490

Open

PDavid added 2 commits December 11, 2024 14:35

HBASE-28832 Fixed unstyled pager link in jqSpager.js

3131a0f

HBASE-28832 Styled Actions forms on Table Details page

59553ca

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526

PDavid commented Dec 10, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526

Are you sure you want to change the base?

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6526

Conversation

PDavid commented Dec 10, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024