HBASE-29027 Introduce a new WALProvider to generate WAL files consumed by Replication #6532

YutSean · 2024-12-11T09:45:38Z

https://issues.apache.org/jira/browse/HBASE-29027

…d by Replication

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

wchevreuil

Thanks for this contribution, I think this would also help reduce wals accumulation in such use cases.

Can we just a UT that validates that we have two wals when using this config?

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALFactory.java

YutSean · 2024-12-12T03:05:04Z

Thanks for this contribution, I think this would also help reduce wals accumulation in such use cases.

Can we just a UT that validates that we have two wals when using this config?

Refined as comments

Reidddddd · 2024-12-12T07:07:45Z

hbase-common/pom.xml

@@ -281,6 +281,14 @@
        <groupId>net.revelc.code</groupId>
        <artifactId>warbucks-maven-plugin</artifactId>
      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>


why introduce it, and still use source 8?

IDE miss import. Reverted the change

wchevreuil

LGTM, +1

Apache-HBase · 2024-12-13T11:27:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	3m 51s		master passed
+1 💚	checkstyle	0m 51s		master passed
+1 💚	spotbugs	2m 5s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	3m 48s		the patch passed
+1 💚	javac	3m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 49s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	2m 26s		the patch passed
+1 💚	hadoopcheck	11m 35s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 16s		The patch does not generate ASF License warnings.
		41m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6532
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux 2e0d0915d30d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33b7e88`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-13T18:27:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 10s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s		master passed
+1 💚	compile	1m 12s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	4m 52s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s		the patch passed
+1 💚	compile	1m 11s		the patch passed
+1 💚	javac	1m 11s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	shadedjars	5m 12s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	3m 2s		hbase-common in the patch passed.
-1 ❌	unit	431m 59s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		461m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6532
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 502c56f1d126 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `33b7e88`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/testReport/
Max. process+thread count	4936 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6532/7/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Sean Xiao Yutong added 2 commits December 11, 2024 17:35

HBASE-29027 Introduce a new WALProvider to generate WAL files consume…

449648b

…d by Replication

Rename variable

bc25864