Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] HBASE-25459:WAL can't be cleaned in some scenes #6619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BsoBird
Copy link

@BsoBird BsoBird commented Jan 21, 2025

The first version of the patch directly used the toString method to get the value of the key. However, if the type of the key is ImmutableByteArray, the toStringUtf8 method should be used to obtain the value. Otherwise, we will end up with the object's hash code.like this:
org.apache.hadoop.hbase.util.ImmutableByteArray@4f

first version patch:https://github.com/apache/hbase/pull/2848/files

The first version of the patch directly used the toString method to get the value of the key. However, if the type of the key is ImmutableByteArray, the toStringUtf8 method should be used to obtain the value. Otherwise, we will end up with the object's hash code.

like this:
org.apache.hadoop.hbase.util.ImmutableByteArray@4f
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 4s master passed
+1 💚 compile 3m 1s master passed
+1 💚 checkstyle 0m 35s master passed
+1 💚 spotbugs 1m 31s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
-1 ❌ mvninstall 1m 16s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 34s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 ⚠️ javac 0m 34s /patch-compile-hbase-server.txt hbase-server in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 33s the patch passed
-1 ❌ spotbugs 0m 34s /patch-spotbugs-hbase-server.txt hbase-server in the patch failed.
-1 ❌ hadoopcheck 1m 36s The patch causes 16 errors with Hadoop v3.3.6.
-1 ❌ hadoopcheck 3m 13s The patch causes 16 errors with Hadoop v3.4.0.
-1 ❌ spotless 0m 34s patch has 27 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
17m 41s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6619
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 79f8870109ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f9998f8
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 29s master passed
+1 💚 compile 1m 15s master passed
+1 💚 javadoc 0m 46s master passed
+1 💚 shadedjars 8m 46s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
-1 ❌ mvninstall 2m 14s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 0m 51s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 ⚠️ javac 0m 51s /patch-compile-hbase-server.txt hbase-server in the patch failed.
+1 💚 javadoc 0m 37s the patch passed
-1 ❌ shadedjars 5m 54s patch has 16 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 0m 58s /patch-unit-hbase-server.txt hbase-server in the patch failed.
26m 26s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6619
Optional Tests javac javadoc unit compile shadedjars
uname Linux e0271ac4d773 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f9998f8
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/testReport/
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6619/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@BsoBird
Copy link
Author

BsoBird commented Jan 21, 2025

@Apache9 Hello,Sir. Can u check this? tks.

@Apache9
Copy link
Contributor

Apache9 commented Jan 23, 2025

We'd better open a new issue to address this since HBASE-25459 has been resolved for a long time.

Do you have a jira account, if not, please follow the guideline in README.md to request one and then open an issue about this change.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants