HBASE-29683 Failed to execute hbase shell command: compact 't1', 'f1', 'MOB'
#7410
+307
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guluo2016
commented
Oct 23, 2025
| } | ||
| if (locations == null || locations.isEmpty()) { | ||
| future.completeExceptionally(new TableNotFoundException(tableName)); | ||
| return; |
There was a problem hiding this comment.
In here, return early to prevent further execution when locations is null
There was a problem hiding this comment.
This should be a separated bug? We can fix this first?
Apache9
reviewed
Nov 1, 2025
| }); | ||
| List<ColumnFamilyDescriptor> mobColumnFamilies = | ||
| Arrays.stream(tableDesc.getColumnFamilies()) | ||
| .filter(ColumnFamilyDescriptor::isMobEnabled).toList(); |
There was a problem hiding this comment.
I do not think toList is available in java 8?
| future.complete(null); | ||
| return; | ||
| } | ||
| if (columnFamily == null) { |
There was a problem hiding this comment.
Seems here we added bunch of code related to MOB feature? What is the implementation on branch-2 for sync HBaseAdmin?
| } | ||
| if (locations == null || locations.isEmpty()) { | ||
| future.completeExceptionally(new TableNotFoundException(tableName)); | ||
| return; |
There was a problem hiding this comment.
This should be a separated bug? We can fix this first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details see: HBASE-29683