HBASE-29557 Decouple dependency on Hadoop AuthenticationFilter classes #7422
+7,304
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make initial commit with hadoop trunk for module hadoop-common-project/hadoop-auth as of commit f3cd00d8db6351dabed286d07f9285a31fc1ecb7as is!
…pendency to new module as needed, drop tests from hbase-auth-filters temporarily (plan is to get first round of review before adjusting/fixing)
|
Build code locally and ran following tests: Waiting for build result to see if all works fine. Also, if the amount of new code being copied looks acceptable, can work on following efforts to get this in:
|
NihalJain
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
|
Added a new commit handling few more cases based on following analysis as per an internal change having hadoop with jetty12 with EE10: |
|
Could you please review this PR and share your feedback? Please read the commit description for full context. In particular, do we agree that the code copy is acceptable? |
… reference script. - Copy more files from hadoop, needed to isolate javax.servlet vs. jakarta.servlet differences, keeping only required methods. - Files identified based on our organisations' (private) Hadoop with Jetty 12 / EE 10 efforts' code change. - Add `check_hadoop_jakarta_impact.sh` for reviewers' context (to be removed in follow-up commit).
NihalJain
force-pushed
the
HBASE-29557
branch
from
c0bb774 to
0a2cbfa
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
I think that the (mostly) copied new files should have a boilerplate comment explaining where they were copied from. |
|
Otherwise it looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes for this PoC (Up to date as of 30th Oct 2025 with 4 commits)
Commit 1: Make initial commit by copying hadoop trunk’s module hadoop-common-project/hadoop-auth into a new module hbase-auth-filters.
Commit 2: Prune unnecessary pieces and wire the new module to HBase.
mvn test -pl hbase-rest,hbase-http,hbase-auth-filters.Commit 3: Address Error Prone to fix compilation issue.
Commit 4: Proactive Jakarta readiness to handle potential Hadoop migration; add reference script.
check_hadoop_jakarta_impact.shfor reviewers' context (to be removed in follow-up commit).mvn test -Dtest=TestFsDelegationToken -pl hbase-server; mvn test -pl hbase-http,hbase-auth-filters,hbase-rest,hbase-thrift.Next steps (dependent on reviewer acceptance of this huge copy of hadoop-auth code for our decoupling initiative)
If PoC is acceptable:
If PoC is not acceptable:
CC: @Apache9, @stoty, @apurtell, @ndimiduk