Support zone based virtual topology assignment algorithm #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkGaox
changed the title
xyuanlu
reviewed
Jan 7, 2025
There was a problem hiding this comment.
We had an offline discussion.
When a new host joining the cluster, the current behavior of virtual group assignment will recompute the whole virtual topology assignment, causing the whole partition assignment shuffle.
I feel like the ideal behavior should be ore sticky. When new hosts are added, the existing hosts' mapping should not change.
| @@ -24,7 +24,12 @@ public class VirtualTopologyGroupConstants { | |||
| public static final String GROUP_NAME = "virtualTopologyGroupName"; | |||
| public static final String GROUP_NUMBER = "virtualTopologyGroupNumber"; | |||
| public static final String AUTO_MAINTENANCE_MODE_DISABLED = "autoMaintenanceModeDisabled"; | |||
| public static final String ASSIGNMENT_ALGORITHM = "virtualTopologyAssignmentAlgorithm"; | |||
There was a problem hiding this comment.
maybe ASSIGNMENT_ALGORITHM_TYPE?
| return _instance; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
signature
Would be great if provide an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Support zone based virtual topology assignment algorithm #2985
Description
This PR support zone based virtual topology assignment algorithm. In the rest service, introduced a configurable parameter enabling users to select the desired virtual topology assignment algorithm (e.g.,instance_based or zone_based). Additionally, implemented a zone-based assignment algorithm that directly maps physical zones to virtual zones.
Tests
Changes that Break Backward Compatibility (Optional)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)