-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add a copy button to the monitoring center #2060
Open
irenhongyan
wants to merge
8
commits into
apache:master
Choose a base branch
from
irenhongyan:feature#1727
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenhongyan
changed the title
Add a copy button to the monitoring center
[feature] Add a copy button to the monitoring center
Jun 2, 2024
hi 👍 lgtm. Recommended that merge this after releasing version 1.6.0. |
I will make the necessary changes as soon as possible.
…------------------ 原始邮件 ------------------
发件人: "apache/hertzbeat" ***@***.***>;
发送时间: 2024年6月16日(星期天) 下午3:16
***@***.***>;
***@***.******@***.***>;
主题: Re: [apache/hertzbeat] [feature] Add a copy button to the monitoring center (PR #2060)
hi, i have a test for this, it seem not copy the monitor params when click copy button.
before:
image.png (view on web)
copy:
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
👍 thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add a copy button to the monitoring center,And realize internationalization。issus is #1727
Checklist
Add or update API