Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] change name from http_sd to registry #2827

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[refactor] change name from http_sd to registry #2827

merged 2 commits into from
Nov 22, 2024

Conversation

Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Nov 21, 2024 •
edited
Loading

What's changed?

The monitor I've changed is to monitor registry so that I monified its name and package.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Nov 21, 2024
tomsun28
tomsun28 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!👍

@tomsun28 tomsun28 merged commit 12f4ecc into apache:master Nov 22, 2024
4 checks passed
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Nov 22, 2024
@tomsun28 tomsun28 added this to the 1.6.2 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation good first pull request Good for newcomers
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Calvin979 @tomsun28 @zuobiao-zhou