Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Delete redundant Spaces #2834

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

ayu-v0
Copy link
Contributor

@ayu-v0 ayu-v0 commented Nov 24, 2024

What's changed?

This PR does not add any logical code, just remove some redundant Spaces to make the code more elegant.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@ayu-v0
Copy link
Contributor Author

ayu-v0 commented Nov 24, 2024

This seems to have caused merge to fail...
image

import org.snmp4j.smi.TimeTicks;
import org.snmp4j.smi.Variable;
import org.snmp4j.smi.VariableBinding;
import org.snmp4j.smi.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid star import, check your package import setting and remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thank you very much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected him

avoid star import

Signed-off-by: ayu-v0 <[email protected]>
Copy link
Member

@zuobiao-zhou zuobiao-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuobiao-zhou zuobiao-zhou merged commit 8cdc92a into apache:master Nov 24, 2024
3 checks passed
@ayu-v0 ayu-v0 deleted the a-feature-branch branch November 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants