HIVE-28876 Strings should be compared with equals(), not with == #5744
Conversation
|
| private static String getMetricStageName(String stageName, ReplicationMetricCollector metricCollector) { | ||
| if( stageName == "REPL_DUMP" || stageName == "REPL_LOAD" || stageName == "ATLAS_DUMP" || stageName == "ATLAS_LOAD" | ||
| || stageName == "RANGER_DUMP" || stageName == "RANGER_LOAD" || stageName == "RANGER_DENY"){ | ||
| if( "REPL_DUMP".equals(stageName) || "REPL_LOAD".equals(stageName) || "ATLAS_DUMP".equals(stageName) || "ATLAS_LOAD".equals(stageName) |
There was a problem hiding this comment.
I do not have to much sentiment if the string is equals or ==. Both are acceptable. I would chime @deniskuzZ and @ayushtkn to tell which is the most commonly used style in Hive.
There was a problem hiding this comment.
In Java the == operator compares only the references not the actual content of the objects so this change is needed here.
There was a problem hiding this comment.
Old code also works because Java uses constant folding at compile time for optimization.
and this stageName comes from private final String STAGE_NAME = "REPL_LOAD";
but to make it consistent with non-final fields, .equals() is a better option.
You can check the first answer from this.
https://stackoverflow.com/questions/8581824/does-java-compiler-include-string-constant-folding
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
5 participants
Comparison with == and != checks memory adresses
equals() check values