Skip to content

fix: Ensure consistent test behavior with NonDex by resolving nondeterministic field order #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Ensure consistent test behavior with NonDex by resolving nondeterministic field order #5765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8002494
fix: Ensure consistent test behavior with NonDex by resolving nondete…
Sep 8, 2024
91e65d2
Merge pull request #1 from RITIKHARIANI/fix-flaky
RITIKHARIANI Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
Expand Down Expand Up @@ -557,6 +558,12 @@ public static StructField getStandardStructFieldRef(String fieldName,
*/
public static Field[] getDeclaredNonStaticFields(Class<?> c) {
Field[] f = c.getDeclaredFields();
Arrays.sort(f, new Comparator<Field>() {
@Override
public int compare(Field a, Field b) {
return a.getName().compareTo(b.getName());
}
});
Comment on lines +561 to +566
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost seems like a test requirement rather than doing it in production code. Can't we pass the fields in sorted order within the test?

ArrayList<Field> af = new ArrayList<Field>();
for (int i = 0; i < f.length; ++i) {
if (!Modifier.isStatic(f[i].getModifiers())) {
Expand Down
Loading