HIVE-28967: Support multiple partitions in RELOAD event #5832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengzhhu653
reviewed
Jun 2, 2025
...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
Show resolved
Hide resolved
dengzhhu653
reviewed
Jun 2, 2025
...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/ReloadMessage.java
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
tests failed
labels
saihemanth-cloudera
force-pushed
the
hive-28967
branch
from
408cdd8 to
d90af91
Compare
asf-ci-hive
added
tests pending
tests failed
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
saihemanth-cloudera
force-pushed
the
hive-28967
branch
from
d90af91 to
3826811
Compare
dengzhhu653
reviewed
Jun 13, 2025
| table, partVals); | ||
| this.ptns = new ArrayList<>(); | ||
| for(List<String> partVal : partVals) { | ||
| this.ptns.add(handler.get_partition(MetaStoreUtils.prependNotNullCatToDbName(catName, db), |
There was a problem hiding this comment.
how about use get_partitions_by_names_req to get all partitions in a round
dengzhhu653
reviewed
Jun 13, 2025
| if (event.getPartitionObj() != null) { | ||
| msg += "partition " + Arrays | ||
| .toString(event.getPartitionObj().getValues().toArray()) + " of "; | ||
| if (event.getPartitions() != null) { |
There was a problem hiding this comment.
if the partitions are large, will the message pollute the whole log file? if we really need it, how about only log the part_vals?
There was a problem hiding this comment.
These partitions spec comes directly from end-user, so this won't big (usually 5-10 partitions). We need entire partition object to identify the self event.
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
dengzhhu653
reviewed
Jun 24, 2025
| import org.apache.hadoop.hive.metastore.api.GetTableRequest; | ||
| import org.apache.hadoop.hive.metastore.api.MetaException; | ||
| import org.apache.hadoop.hive.metastore.api.NoSuchObjectException; | ||
| import org.apache.hadoop.hive.metastore.api.Partition; | ||
| import org.apache.hadoop.hive.metastore.api.Table; | ||
| import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils; | ||
| import org.apache.thrift.TException; | ||
| //import org.datanucleus.store.types.wrappers.ArrayList; |
There was a problem hiding this comment.
nit: you may need to remove this commented line, leave it to you to decide.
dengzhhu653
approved these changes
Jun 24, 2025
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To support multiple partitions in the Reload event
Why are the changes needed?
Clients like Impala can use this fire multiple partitions in a single RELOAD event
Does this PR introduce any user-facing change?
No
How was this patch tested?
Local