Skip to content

HIVE-29043: Ban the Jupiter dependency from hive-unit to prevent unit tests from being skipped #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+28 −12
Open

HIVE-29043: Ban the Jupiter dependency from hive-unit to prevent unit tests from being skipped #5894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions itests/hive-unit/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,33 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-banned-dependencies</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<bannedDependencies>
<excludes>
<exclude>org.junit.jupiter:junit-jupiter</exclude>
</excludes>
<searchTransitive>true</searchTransitive>
<message>
Banned jupiter dependency was found!
Only remove this rule if you confirmed that adding jupiter dependency
to the project won't make unit tests silently skipped.
</message>
</bannedDependencies>
</rules>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
13 changes: 1 addition & 12 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,7 +1664,7 @@
</configuration>
</execution>
<execution>
<id>enforce-banned-dependencies-licenses</id>
<id>enforce-banned-dependencies</id>
<goals>
<goal>enforce</goal>
</goals>
Expand All @@ -1677,17 +1677,6 @@
</excludes>
<message>A banned license dependency was found!</message>
</bannedDependencies>
</rules>
<fail>true</fail>
</configuration>
</execution>
<execution>
<id>enforce-banned-dependencies-logging</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<bannedDependencies>
<excludes>
<!-- Move to SLF4J -->
Expand Down
Loading