HIVE-29116 : Create a DDL for setting hive default partition name at the table level

[vikramahuja1001]

1. Expose a DDL to set default partition name at table level
2. Restrict set hive.exec.default.partition at runtime
3. use table property to check the default partition along with hive.exec.default.partition at cluster level

For more details refer: https://issues.apache.org/jira/browse/HIVE-29116

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

[vikramahuja1001]

@deniskuzZ , @chinnaraolalam could you please take a look at this PR?

[ngsg]

Hi @vikramahuja1001, I have the same concern about setting the default partition name, and I'm glad to see the patch addressing it. I have reviewed the changes, except for HiveAlterHandler.java (I need more time to study the changes and the relevant context), and left comments on the places where I have questions. Could you please review my comments on the changes?

[Indhumathi27]

Can you add a test to validate hive.exec.default.partition.name is no more session configurable

[vikramahuja1001]

Thanks for reviewing this PR @ngsg @Indhumathi27
I will handle the review comments, push the changes soon.

[Aggarwal-Raghav]

@vikramahuja1001 , i think change is required in org.apache.hadoop.hive.ql.exec.DDLPlanUtils#checkIfDefaultPartition()

hive/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLPlanUtils.java

Line 307 in 7350329

if (pt.contains(HIVE_DEFAULT_PARTITION)) {

[Aggarwal-Raghav]

Remove hardcoding from here as well + update comments as well accordingly
org.apache.hadoop.hive.common.FileUtils#escapePathName(java.lang.String, java.lang.String)

hive/common/src/java/org/apache/hadoop/hive/common/FileUtils.java

Line 298 in 413069e

return "__HIVE_DEFAULT_PARTITION__";

hive/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java

Line 310 in 90820ac

return "__HIVE_DEFAULT_PARTITION__";

[Aggarwal-Raghav]

Remove hardcoding from following place:

hive/hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java

Line 715 in 733d4f0

dynPathSpec = dynPathSpec.replace("__HIVE_DEFAULT_PARTITION__", "*");

hive/hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatFileUtil.java

Line 71 in ba0217f

sb.append("__HIVE_DEFAULT_PARTITION__");

[vikramahuja1001]

@Aggarwal-Raghav ,very good point, makes sense. Thanks for pointing this out. There are indeed a lot of places where HIVE_DEFAULT_PARTITION is hard coded. Have put a few commits to fix that.

[sonarqubecloud]

Quality Gate passed

Issues
66 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarQube Cloud