HIVE-29230: Iceberg: Reads fails after Schema evolution with complex type columns #6106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
changed the title
deniskuzZ
reviewed
Sep 29, 2025
iceberg/iceberg-handler/src/test/queries/positive/iceberg_add_complex_column.q
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Sep 29, 2025
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java
Show resolved
Hide resolved
difin
reviewed
Sep 29, 2025
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java
Outdated
Show resolved
Hide resolved
|
LGTM. I added a minor suggestion to explain in the comment how this adds support for schema evolution. |
difin
approved these changes
Sep 29, 2025
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
deniskuzZ
reviewed
Sep 30, 2025
iceberg/iceberg-handler/src/test/queries/positive/iceberg_add_complex_column.q
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prevent Reads from failing after schema evolution with complex column types
Why are the changes needed?
To prevent reads from failing after we add a complex type column to an existing table with data
Does this PR introduce any user-facing change?
Yes, reads don't fail after adding a complex type column
How was this patch tested?
UT