HIVE-29284 Remove tight yarn-registry coupling from hive-exec #6146
+37
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hadoop-yarn-registry is also not needed for clusters managed by Kubernetes. |
deniskuzZ
reviewed
Oct 22, 2025
| } | ||
|
|
||
| private void addJarLRByClassName(ClassLoader loader, String className, final Map<String, LocalResource> lrMap) throws IOException { | ||
| String jarPath = Utilities.jarFinderGetJar(loader, className); |
There was a problem hiding this comment.
can we do this instead:
Class<?> clazz = Class.forName(className, true, Utilities.getSessionSpecifiedClassLoader())
addJarLRByClass(clazz, lrMap)
deniskuzZ
reviewed
Oct 22, 2025
| addJarLRByClass(LlapProtocolClientProxy.class, commonLocalResources); | ||
| addJarLRByClass(RegistryOperations.class, commonLocalResources); | ||
| addJarLRByClassName( | ||
| getClass().getClassLoader(), |
There was a problem hiding this comment.
why pass the classloader and not init it directly inside the addJarLRByClassName?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I am proposing to remove the tight dependency coupling between
hive-execandhadoop-yarn-registry(to address HIVE-29284).Why are the changes needed?
hive-execpulls inhadoop-yarn-registryas a direct dependency, but registry classes are only used for building a local resource map for LLAP. This map can be built without the actual class instances getting loaded, using class name literals only. Removinghadoop-yarn-registryas a direct dependency will prevent pulling in its whole transitive dependency tree when one only wants to usehive-execfunctionality without LLAP. (e.g apache spark)Does this PR introduce any user-facing change?
No
How was this patch tested?
This patch will be tested by the pre merge tests executed for this pull request.