HIVE-25189: Addendum: Cache validWriteIdList #6153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
force-pushed
the
callAndCacheValidTxnWriteIdList
branch
from
8898a33 to
ba185de
Compare
deniskuzZ
force-pushed
the
callAndCacheValidTxnWriteIdList
branch
from
ba185de to
8adeec7
Compare
deniskuzZ
changed the title
deniskuzZ
changed the title
deniskuzZ
changed the title
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
deniskuzZ
force-pushed
the
callAndCacheValidTxnWriteIdList
branch
from
8adeec7 to
21eae09
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
deniskuzZ
force-pushed
the
callAndCacheValidTxnWriteIdList
branch
from
21eae09 to
8b811c5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reintroduce caching of validWriteIdList for query used tables in a single step. Previously, CacheTableHelper attempted to retrieve it without even considering the table type and assumed an active transaction. Now, a transaction is opened only when necessary, making CacheTableHelper obsolete.
Why are the changes needed?
Performance/resource optimization
Does this PR introduce any user-facing change?
No
How was this patch tested?
Jenkins