Skip to content

Commit

Permalink
Remove unnecessary APLOGNO() use in TRACE-level logging.
Browse files Browse the repository at this point in the history
Submitted by: Jackie Chang <jackie.qq.chang gmail.com>
PR: 55627


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1913338 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
notroj committed Oct 26, 2023
1 parent 82eaba1 commit df12656
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion modules/ldap/util_ldap.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ static int uldap_connection_init(request_rec *r,

if (ldc->ChaseReferrals != AP_LDAP_CHASEREFERRALS_SDKDEFAULT) {
/* Set options for rebind and referrals. */
ap_log_error(APLOG_MARK, APLOG_TRACE4, 0, r->server, APLOGNO(01278)
ap_log_error(APLOG_MARK, APLOG_TRACE4, 0, r->server,
"LDAP: Setting referrals to %s.",
((ldc->ChaseReferrals == AP_LDAP_CHASEREFERRALS_ON) ? "On" : "Off"));
apr_ldap_set_option(r->pool, ldc->ldap,
Expand Down
6 changes: 3 additions & 3 deletions modules/lua/mod_lua.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ static ap_lua_vm_spec *create_vm_spec(apr_pool_t **lifecycle_pool,
else {
spec->file = r->filename;
}
ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r, APLOGNO(02313)
ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r,
"%s details: scope: %s, file: %s, func: %s",
what, scope_to_string(spec->scope), spec->file,
function ? function : "-");
Expand Down Expand Up @@ -288,7 +288,7 @@ static int lua_handler(request_rec *r)
) {
return DECLINED;
}
ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, APLOGNO(01472)
ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
"handling [%s] in mod_lua", r->filename);

/* XXX: This seems wrong because it may generate wrong headers for HEAD requests */
Expand All @@ -308,7 +308,7 @@ static int lua_handler(request_rec *r)
ap_lua_release_state(L, spec, r);
return HTTP_INTERNAL_SERVER_ERROR;
}
ap_log_rerror(APLOG_MARK, APLOG_TRACE3, 0, r, APLOGNO(01474) "got a vm!");
ap_log_rerror(APLOG_MARK, APLOG_TRACE3, 0, r, "got a vm!");
lua_getglobal(L, "handle");
if (!lua_isfunction(L, -1)) {
ap_log_rerror(APLOG_MARK, APLOG_CRIT, 0, r, APLOGNO(01475)
Expand Down
2 changes: 1 addition & 1 deletion modules/proxy/ajp_header.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ static apr_status_t ajp_marshal_into_msgb(ajp_msg_t *msg,
ap_log_rerror(APLOG_MARK, APLOG_TRACE8, 0, r, "Into ajp_marshal_into_msgb");

if ((method = sc_for_req_method_by_id(r)) == UNKNOWN_METHOD) {
ap_log_rerror(APLOG_MARK, APLOG_TRACE8, 0, r, APLOGNO(02437)
ap_log_rerror(APLOG_MARK, APLOG_TRACE8, 0, r,
"ajp_marshal_into_msgb - Sending unknown method %s as request attribute",
r->method);
method = SC_M_JK_STORED;
Expand Down

0 comments on commit df12656

Please sign in to comment.