Fixing Null pointer exception in finally block

apache · Aug 22, 2018 · 3746ace · 3746ace
1 parent 88274b8
commit 3746ace
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java b/hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java
@@ -296,7 +296,9 @@ public List<HoodieRollbackStat> rollback(JavaSparkContext jsc, List<String> comm
                                 "Failed to rollback for commit " + commit, io);
                           } finally {
                             try {
-                              writer.close();
+                              if (writer != null) {
+                                writer.close();
+                              }
                             } catch (IOException io) {
                               throw new UncheckedIOException(io);
                             }

diff --git a/hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieLogFormatWriter.java b/hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieLogFormatWriter.java
@@ -72,6 +72,7 @@ public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
       try {
         this.output = fs.append(path, bufferSize);
       } catch (RemoteException e) {
+        log.warn("Remote Exception, attempting to handle or recover lease", e);
         handleAppendExceptionOrRecoverLease(path, e);
       } catch (IOException ioe) {
         if (ioe.getMessage().equalsIgnoreCase("Not supported")) {