Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs table horizontal scroll fix #11845

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

pintusoliya
Copy link

Change Logs

Describe context and summary for this change. Highlight if any code was copied.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@danny0405
Copy link
Contributor

@pintusoliya cool fix, can you paste some discrepency contrast of the site before/after this change, that would be very intuititive for reviewers.

@github-actions github-actions bot added docs size:M PR with lines of changes in (100, 300] labels Aug 28, 2024
@bhasudha
Copy link
Contributor

Tested lcoally.
older one with issue where the configs table has a horizontal slide:
image

newer one with the changes in the PR where the config table is contained within the window:
image

@bhasudha bhasudha self-requested a review August 29, 2024 00:01
Copy link
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhasudha bhasudha merged commit 6d7a6ad into apache:asf-site Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs size:M PR with lines of changes in (100, 300]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants