[HUDI-8484] Instant heartbeats memory leak #12212
Open
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
added
resource-leak
priority:critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The heartbeat should be removed from memory when it has been explicitly stopped (in the post-commit step, which means the instant has been committed), otherwise the heartbeat is left in memory until the write client has been stopped entirely. In streaming pipeline, the write client is been reused for multiple instants.
The heartbeats are mainly designed for lazy cleaning and very probaly the clean table service is executed asynchronously on another workload, the in-memory heatbeat does not make any sense for a committed instant actually.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist