refactor: replace std::any placeholder with Literal #130
+10
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
changed the title
lidavidm
approved these changes
Jun 27, 2025
|
CI failure is unrelated (downloading thrift dependency timed out) |
mapleFU
approved these changes
Jun 27, 2025
| /// TODO(zhjwpku): use StructLike to represent partition data tuple | ||
| std::any partition; | ||
| /// field ids | ||
| std::vector<Literal> partition; |
There was a problem hiding this comment.
This is ok to me, and should we extract a Literals or StructLike type using Vector<Literal>, or just leave it here?
There was a problem hiding this comment.
I think we can add an optimized data structure for single value partition later or simply add something like https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/small_vector.h
Literal can be used for partition value and default value
Fokko
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literal can be used for partition values and default values