feat: add table create/replace/update interface to catalog #281
+90
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
reviewed
Nov 2, 2025
| /// May throw ValidationException if any update cannot be applied to the current table | ||
| /// metadata. May throw CommitFailedException if the updates cannot be committed due to | ||
| /// conflicts. | ||
| virtual void CommitTransaction() = 0; |
Contributor
There was a problem hiding this comment.
Do we want to keep backward compatibility with deprecation e.g.
[[deprecated("Use CommitTransaction() that returns Status")]]
Member
There was a problem hiding this comment.
I think we can break any existing API before 1.0.0. We just released 0.1.0 a while ago and I don't think it is ready for production yet.
src/iceberg/catalog.h
Outdated
|
|
||
| /// \brief Starts a transaction to create or replace the table | ||
| /// | ||
| /// \breturn the Transaction to create or replace the table |
Contributor
Author
There was a problem hiding this comment.
Good catch! Fixed the typo.
src/iceberg/table.h
Outdated
| /// \brief Create a new transaction for this table | ||
| /// | ||
| /// \return a shared pointer to the new Transaction | ||
| virtual std::shared_ptr<Transaction> NewTransaction(); |
Contributor
There was a problem hiding this comment.
We don't want to add 'const' just like NewScan() and io()?
Contributor
Author
There was a problem hiding this comment.
Yes, it should be const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.