Fix table_exists behavior in REST catalog
#1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Aug 23, 2024
| @@ -701,17 +702,17 @@ def test_load_table_404(rest_mock: Mocker) -> None: | |||
| assert "Table does not exist" in str(e.value) | |||
|
|
|||
|
|
|||
| def test_table_exist_200(rest_mock: Mocker) -> None: | |||
| def test_table_exists_200(rest_mock: Mocker) -> None: | |||
There was a problem hiding this comment.
This is interesting, the integration tests aren't working?
There was a problem hiding this comment.
We don’t have integration tests for the catalog interactions, so I created an issue to implement a test suite: #1010
Fokko
changed the title
table_exists behavior in REST catalog
Fokko
approved these changes
Aug 23, 2024
sungwy
approved these changes
Aug 24, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that it might seem odd to return false for a 200 status code, but according to the specification, success should only be indicated by a 204 status code. Additionally, it doesn’t make sense to throw an exception for a 404 status code since a table_exists method is expected to return True or False, not just True or an exception.
If a user needs to handle exceptions, they can use the load_table method, which will return an exception if the table does not exist.
Solves: #1018