-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support S3 Table Buckets with S3TablesCatalog #1429
Open
felixscherz
wants to merge
66
commits into
apache:main
Choose a base branch
from
felixscherz:feat/s3tables-catalog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,110
−8
Open
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
0c8fa1b
feat: initial setup for S3TablesCatalog
felixscherz 1ca5e86
feat: support create_table using FsspecFileIO
felixscherz e659da1
feat: implement drop_table
felixscherz 9973d12
feat: implement drop_namespace
felixscherz 3c36450
test: validate how version conflict is handled with s3tables API
felixscherz c876a37
feat: implement commit_table
felixscherz 43deab4
feat: implement table_exists
felixscherz 907ed28
feat: implement list_tables
felixscherz 4438c8e
refactor: improve list_namespace
felixscherz 3499643
fix: return Identifier from list_tables
felixscherz fef4e69
feat: implement rename table
felixscherz 85d9bf5
feat: implement load_namespace_properties
felixscherz 1360ead
refactor: move some methods around
felixscherz 6951076
feat: raise NotImplementedError for views functionality
felixscherz 28ef842
feat: raise NotImplementedError for purge_table
felixscherz ff168f2
feat: raise NotImplementedError for update_namespace_properties
felixscherz cf244bd
feat: raise NotImplementedError for register_table
felixscherz f1de32b
fix: don't override create_table_transaction
felixscherz 9fbc402
chore: run formatter
felixscherz 4639e1e
feat: raise exceptions if boto3 doesn't support s3tables
felixscherz 6b4d258
feat: make endpoint configurable
felixscherz ed0cba6
feat: explicitly configure tableBucketARN
felixscherz 49355e2
fix: remove defaulting to FsspecIO
felixscherz 61c4e9c
feat: raise exceptions for invalid namespace/table name
felixscherz a164e77
feat: improve error handling for create_table
felixscherz 37bd609
feat: improve error handling for delete_table
felixscherz 63f8525
chore: cleanup comments
felixscherz da91a11
feat: catch missing metadata for load_table
felixscherz bd5be82
feat: handle missing namespace and preexisting table
felixscherz c15ffdb
feat: handle versionToken and table in an atomic operation
felixscherz dceb55d
chore: run formatter
felixscherz 3114424
chore: add type hints for tests
felixscherz 1dda96d
fix: no longer enforce FsspecFileIO
felixscherz 99d272d
test: remove tests for boto3 behavior
felixscherz c060ad9
test: verify column was created on commit
felixscherz da6516b
test: verify new data can be committed to table
felixscherz 9f890c2
docs: update documentation for create_table
felixscherz ee93da2
test: set AWS regions explicitly
felixscherz 0952b55
Apply suggestions from code review
felixscherz 27414e1
test: commit new data to table
felixscherz 2a8c5c4
feat: clarify update_namespace_properties error
felixscherz 80884a6
feat: raise error when setting custom namespace properties
felixscherz a6a112f
refactor: change S3TableCatalog -> S3TablesCatalog
felixscherz 662b5ea
feat: raise error on specified table location
felixscherz 1cb6f68
feat: return empty list when querying a hierarchical namespace
felixscherz c110d71
refactor: use get_table_metadata_location instead of get_table
felixscherz 3d2f749
refactor: extract 'ICEBERG' table format into constant
felixscherz 44d7a1f
feat: change s3tables.table-bucket-arn -> s3tables.warehouse
felixscherz 9c828e3
Apply suggestions from code review
felixscherz 517f31d
feat: add link to naming-rules for invalid name errors
felixscherz 83739d5
feat: delete s3 table if writing new_table_metadata is unsuccessful
felixscherz 1475f5b
chore: run linter
felixscherz 9ceea4b
test: rename test_s3tables.py -> integration_test_s3tables.py
felixscherz 930cc3e
fix: add license to files
felixscherz 73cf922
fix: raise error when creating a table during a transaction
felixscherz bbc5706
test: mark create_table_transaction test wiht xfail
felixscherz bad0eb5
feat: raise NotImplementedError for view_exists
felixscherz 38c4e6f
test: use moto server for s3tables tests
felixscherz 937d6af
docs: add s3tables catalog
felixscherz cf03cba
chore: bump moto library
felixscherz af6bce7
test: set region when creating table bucket
felixscherz 6af3391
test: mock aws credentials
felixscherz 018bf0b
chore: update poetry lock with s3tables
felixscherz cbfbedd
Merge branch 'main' into feat/s3tables-catalog
kevinjqliu f738e59
use new locationprovider for metadata location
kevinjqliu df97205
fix test region
kevinjqliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 default is False
iceberg-python/pyiceberg/serializers.py
Line 123 in 300b840