Skip to content

Commit

Permalink
use abi3
Browse files Browse the repository at this point in the history
  • Loading branch information
sungwy committed Nov 24, 2024
1 parent a4e6d66 commit 0c5b0f5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
19 changes: 13 additions & 6 deletions .github/workflows/release_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,21 @@ jobs:
name: wheels
path: bindings/python/dist

linux:
runs-on: ubuntu-latest
wheels:
runs-on: "${{ matrix.os }}"
strategy:
matrix:
target: [ x86_64, aarch64, armv7l ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
include:
- { os: windows-latest }
- { os: macos-latest, target: "universal2-apple-darwin" }
- { os: ubuntu-latest, target: "x86_64" }
- { os: ubuntu-latest, target: "aarch64" }
- { os: ubuntu-latest, target: "armv7l" }
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: 3.9
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
Expand All @@ -72,7 +79,7 @@ jobs:
manylinux: auto
working-directory: "bindings/python"
command: build
args: --release -o dist -i python${{ matrix.python-version }}
args: --release -o dist
env:
# Workaround ring 0.17 build issue
CFLAGS_aarch64_unknown_linux_gnu: "-D__ARM_ARCH=8"
Expand All @@ -84,7 +91,7 @@ jobs:

pypi-publish:
name: Publish Python 🐍 distribution 📦 to Pypi
needs: [ sdist, linux ]
needs: [ sdist, wheels ]
runs-on: ubuntu-latest
# Only publish to PyPi if the tag is not a pre-release
if: ${{ startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-') }}
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ crate-type = ["cdylib"]

[dependencies]
iceberg = { path = "../../crates/iceberg" }
pyo3 = { version = "0.22.3", features = ["extension-module"] }
pyo3 = { version = "0.22.3", features = ["extension-module", "abi3-py39"] }
arrow = { version = "53", features = ["pyarrow"] }

0 comments on commit 0c5b0f5

Please sign in to comment.