fix: Remove check of last_column_id (#717)

* Remove check of last_column_id Signed-off-by: liurenjie1024 <[email protected]> * Remove dead code --------- Signed-off-by: liurenjie1024 <[email protected]>
apache · Nov 27, 2024 · ce04058 · ce04058
1 parent d3b7f56
commit ce04058
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 23 deletions.
diff --git a/crates/iceberg/src/catalog/mod.rs b/crates/iceberg/src/catalog/mod.rs
@@ -453,23 +453,7 @@ impl TableUpdate {
     pub fn apply(self, builder: TableMetadataBuilder) -> Result<TableMetadataBuilder> {
         match self {
             TableUpdate::AssignUuid { uuid } => Ok(builder.assign_uuid(uuid)),
-            TableUpdate::AddSchema {
-                schema,
-                last_column_id,
-            } => {
-                if let Some(last_column_id) = last_column_id {
-                    if builder.last_column_id() > last_column_id {
-                        return Err(Error::new(
-                            ErrorKind::DataInvalid,
-                            format!(
-                                "Invalid last column ID: {last_column_id} < {} (previous last column ID)",
-                                builder.last_column_id()
-                            ),
-                        ));
-                    }
-                };
-                Ok(builder.add_schema(schema))
-            }
+            TableUpdate::AddSchema { schema, .. } => Ok(builder.add_schema(schema)),
             TableUpdate::SetCurrentSchema { schema_id } => builder.set_current_schema(schema_id),
             TableUpdate::AddSpec { spec } => builder.add_partition_spec(spec),
             TableUpdate::SetDefaultSpec { spec_id } => builder.set_default_partition_spec(spec_id),

diff --git a/crates/iceberg/src/spec/table_metadata_builder.rs b/crates/iceberg/src/spec/table_metadata_builder.rs
@@ -188,12 +188,6 @@ impl TableMetadataBuilder {
         )
     }
 
-    /// Get the current last column id
-    #[inline]
-    pub(crate) fn last_column_id(&self) -> i32 {
-        self.metadata.last_column_id
-    }
-
     /// Changes uuid of table metadata.
     pub fn assign_uuid(mut self, uuid: Uuid) -> Self {
         if self.metadata.table_uuid != uuid {