Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Convert predicate to arrow filter and push down to parquet reader #295

Merged
merged 21 commits into from
May 15, 2024
Merged

feat: Convert predicate to arrow filter and push down to parquet reader #295

merged 21 commits into from
May 15, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 24, 2024 •
edited
Loading

This implements the feature of row filtering when reading Parquet files in Iceberg scan. It is achieved by converting predicates into Parquet Arrow filter which is used to filter rows during reading in Parquet reader.

This implements AlwaysTrue, AlwaysFalse, And, Or, Not, Binary, partial Unary predicates. Unimplemented predicates (some Unary and Set predicates) are because no existing kernels to be used in arrow. I'll implement them in following works.

close #265

@viirya viirya force-pushed the filter_to_row_filter branch from c9e53f0 to 22af140 Compare March 24, 2024 05:45
@viirya viirya marked this pull request as draft March 24, 2024 17:26
@viirya viirya force-pushed the filter_to_row_filter branch 3 times, most recently from 5606bbe to 67c3f05 Compare March 25, 2024 00:43
@viirya viirya marked this pull request as ready for review March 25, 2024 00:43
@viirya viirya force-pushed the filter_to_row_filter branch from 67c3f05 to 9262774 Compare March 25, 2024 00:50
viirya
viirya commented Mar 26, 2024
View reviewed changes
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
viirya
viirya commented Mar 26, 2024
View reviewed changes
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
@liurenjie1024
Copy link
Contributor

cc @viirya Is this ready for review or you still need to do more update?

@viirya
Copy link
Member Author

viirya commented Apr 1, 2024

@liurenjie1024 It is ready for review. I will fix the conflicts.

liurenjie1024
liurenjie1024 reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @viirya Thanks for this pr, the general idea of reusing arrow kernel looks great! But I found some small problems which could be improved.

crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow.rs Outdated
PredicateOperator::NotNull => Ok(Box::new(ArrowPredicateFn::new(
self.projection_mask.clone(),
move |batch| {
let column = batch.column(term_index);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This maybe incorrect for nested column, I think maybe we should either return projection_mask for each leave column, or implement a general purpose flatten method for struct array.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Parquet reader API will flatten required columns based on the projection_mask we provide. I.e., If the projection mask selects one nested column a.b, it will be the first column of the record batch when calling evaluate of ArrowPredicate API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some test but it seems that it doesn't work like this, say the schem is like following:

message {
  struct a {
    int b
  }
}

And we pass ProjectionMask::leaves([0]), it will return struct array, so batch.column[term_index] will return StructArray

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's what I got from reading the Parquet code. Let me take further look and test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wrote a test to test it in arrow-rs. Yea, for a nested column such as struct.a, the batch passed to evaluate contains a struct array with the column a. Looks like Parquet will project the requested column indices and construct the upper nested type (i.e., struct) before passing to evaluate,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test to arrow-rs to clarify its usage: apache/arrow-rs#5600

Copy link
Member Author

@viirya viirya Apr 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to have a flatten method for struct array sounds more simple way. I'm looking in arrow-rs to see if there is existing one, if not, we need to implement it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This maybe incorrect for nested column, I think maybe we should either return projection_mask for each leave column, or implement a general purpose flatten method for struct array.

I tried to change to return projection_mask for each leave column, it is pretty straightforward to implement. Please let me know if it looks good to you. Thanks.

@viirya viirya mentioned this pull request Apr 3, 2024
Closed
@viirya
Copy link
Member Author

viirya commented Apr 3, 2024

I've addressed some of above reviews. I will resolve other reviews soon. Thanks.

@viirya viirya mentioned this pull request Apr 7, 2024
Merged
@viirya
Copy link
Member Author

viirya commented Apr 12, 2024

@liurenjie1024 I've addressed all comments. Thank you.

liurenjie1024
liurenjie1024 reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya for this pr, it looks promising! Given #334 has been merged, do you mind to rewrite some of the visitors with new api? This helps to make code easier to maintain.

crates/iceberg/src/arrow/reader.rs Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Show resolved Hide resolved
@Fokko Fokko mentioned this pull request Apr 24, 2024
Closed
73 tasks
@viirya
Copy link
Member Author

viirya commented Apr 28, 2024

@liurenjie1024 Thanks for review. Sorry for late. I addressed the comments by rewriting the visitors using the new API. I replied with another questions.

liurenjie1024
liurenjie1024 reviewed Apr 28, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya for this great pr! It's really hard work, and you did it in a quite elegant way. I found some small problems to fix.

crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated
fn always_true(&mut self) -> Result<Self::T> {
Ok(Box::new(ArrowPredicateFn::new(
self.projection_mask.clone(),
|batch| Ok(BooleanArray::from(vec![true; batch.num_rows()])),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This maybe not a blocker, but is it possible to build a const array in arrow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I know, there is no const array in arrow for now. It has dictionary array which I think is close to const array, but the ArrowPredicateFn API defines returned type to be BooleanArray.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue to track this: apache/arrow-rs#5701

crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated
reference: &BoundReference,
_predicate: &BoundPredicate,
) -> Result<Self::T> {
let projected_mask = self.bound_reference(reference)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incorrect to me. Let's say the predicate is a is null AND b >1, then the batch passed to this ArrowPredicateFn is constructed by projection mask of [a, b]. I think one possible solution is to use same project mask for all predicates, and pass the column_idx to get_leaf_column.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, as RowFilter API design accepts multiple ArrowPredicates. Each ArrowPredicate has its projection and the API doc said the API will be passed batches that contains the columns specified in projection. I think it should be projected for each ArrowPredicate and projection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go to test it in arrow-rs to verify it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, although I used multiple ArrowPredicates before, it was changed to one ArrowPredicates after you suggested. So now we generate only one ArrowPredicates.

Hmm, let me think how do deal with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we use one ArrowPredicates to represent the entire predicate, we should use one projection mask which contains all leaf columns in the predicate.

But it brings another question, how do we access the correct array from the RecordBatch. For top-level column, it should be straightforward, but for nested column, I don't find a way to get it quickly.

I created one issue at arrow-rs: apache/arrow-rs#5699

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what I searched and the kindly reply on the issue, I think there is no way to do nested projection on RecordBatch currently.

To implement the feature in arrow-rs might block this. I tend to finish top-level column only in this PR.

WDYT, @liurenjie1024 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we can support top-level column only first to move on.

crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/scan.rs
}

#[tokio::test]
async fn test_filter_on_arrow_is_not_null() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests, is it possible to add serveral test cases for more complex types such as AND, OR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I added some more tests using AND and OR.

@viirya viirya mentioned this pull request Apr 29, 2024
Open
@liurenjie1024 liurenjie1024 mentioned this pull request Apr 29, 2024
Open
liurenjie1024
liurenjie1024 reviewed Apr 29, 2024
View reviewed changes
crates/iceberg/src/arrow/reader.rs Outdated
},
)))
} else {
self.build_always_true()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a column is missing, I think we should treat it as null, so this should be false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed it.

crates/iceberg/src/arrow/reader.rs
Ok(BooleanArray::from(vec![true; batch.num_rows()]))
})))
} else {
self.build_always_true()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iceberg spec has no definition for NULL is_nan, but java defines it as false: https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/util/NaNUtil.java#L25

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
crates/iceberg/src/arrow/reader.rs Outdated
},
)))
} else {
self.build_always_true()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java impl comparator uses null first: https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/expressions/Literals.java#L616

I think we should return false here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

crates/iceberg/src/arrow/reader.rs Outdated Show resolved Hide resolved
@viirya viirya force-pushed the filter_to_row_filter branch from 49721e8 to c36560c Compare May 8, 2024 03:56
@viirya
Copy link
Member Author

viirya commented May 10, 2024

@liurenjie1024 I've addressed your comments. Please take a look when you can. Thanks.

liurenjie1024
liurenjie1024 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya for this effort!

@liurenjie1024
Copy link
Contributor

Oh, sorry, seems we need to resolve conflicts. Others LGTM, thanks!

@viirya
Copy link
Member Author

viirya commented May 14, 2024

Thanks @liurenjie1024. I just resolved the conflicts.

@liurenjie1024
Copy link
Contributor

Thanks @viirya for this great effort!

@liurenjie1024 liurenjie1024 merged commit 81df940 into apache:main May 15, 2024
7 checks passed
@viirya
Copy link
Member Author

viirya commented May 15, 2024

Thanks @liurenjie1024 for your review!

@sdd sdd mentioned this pull request Jun 18, 2024
Closed
github-merge-queue bot pushed a commit to risingwavelabs/iceberg-rust that referenced this pull request Sep 9, 2024
@chenzl25 @Xuanwo
@liurenjie1024 @Fokko @dependabot @hiirrxnn @Tyler-Sch @ZENOTME @odysa @JanKaul @manuzhang @Dysprosium0626 @dp-0 @zhenglin-charlie-li @DeaconDesperado @fqaiser94 @sdd @s-akhtar-baig @stream2000 @viirya @marvinlanhenke @mlanhenke @lewiszlw @a-agmon @TennyZhuang @waynexia @himadripal @whynick1 @QuakeWang @gupteaj @c-thiel @rwwwx @jdockerty @vivek378521 @shoothzj @vaibhawvipul @thexiay @yinheli @nooberfsh @xxchan @ndrluis @alexyin1 @SteveLauC @AndreMouche @callum-ryan @twuebi @mattheusv @FANNG1 @ChinoUkaegbu @sungwy @Sl1mb0 @sdlarsen
Merge upstream (#1)
f60c288 
* feat: Add website layout (#130)

* feat: Add website layout

Signed-off-by: Xuanwo <[email protected]>

* publish to rust.i.a.o

Signed-off-by: Xuanwo <[email protected]>

* Fix license

Signed-off-by: Xuanwo <[email protected]>

* Let's try mdbook action

Signed-off-by: Xuanwo <[email protected]>

* use cargo install

Signed-off-by: Xuanwo <[email protected]>

* disable section

Signed-off-by: Xuanwo <[email protected]>

* Add docs for website

Signed-off-by: Xuanwo <[email protected]>

* Fix license

Signed-off-by: Xuanwo <[email protected]>

* action approved

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* feat: Expression system. (#132)

* feat: Expressions

* Fix comments

* Refactor expression to be more similar to iceberg model

* Fix typo

* website: Fix typo in book.toml (#136)

Signed-off-by: Xuanwo <[email protected]>

* Set ghp_path and ghp_branch properties (#138)

* chore: Upgrade toolchain to 1.75.0 (#140)

* feat: Add roadmap and features status in README.md (#134)

* feat: Add roadmap and features status in README.md

* Fix

* Fix

* Add more details according to comments

* Revert unnecessary new line break

* Nits

---------

Co-authored-by: Fokko Driesprong <[email protected]>

* Infra: Remove `publish:` section from `.asf.yaml` (#141)

* chore(deps): Bump peaceiris/actions-gh-pages from 3.9.2 to 3.9.3 (#143)

Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.2 to 3.9.3.
- [Release notes](https://github.com/peaceiris/actions-gh-pages/releases)
- [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md)
- [Commits](https://github.com/peaceiris/actions-gh-pages/compare/v3.9.2...v3.9.3)

---
updated-dependencies:
- dependency-name: peaceiris/actions-gh-pages
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Update opendal requirement from 0.43 to 0.44 (#142)

Updates the requirements on [opendal](https://github.com/apache/incubator-opendal) to permit the latest version.
- [Release notes](https://github.com/apache/incubator-opendal/releases)
- [Changelog](https://github.com/apache/incubator-opendal/blob/main/CHANGELOG.md)
- [Commits](https://github.com/apache/incubator-opendal/compare/v0.43.0...v0.43.0)

---
updated-dependencies:
- dependency-name: opendal
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: Change homepage to rust.i.a.o (#146)

* feat: Introduce basic file scan planning. (#129)

* Code complete

* Resolve

* Done

* Fix comments

* Fix comments

* Fix comments

* Fix

* Fix comment

* chore: Update contributing guide. (#163)

* chore: Update reader api status (#162)

* chore: Update reader api status

* Restore unnecessary change

* #154 : Add homepage to Cargo.toml (#160)

* Add formatting for toml files (#167)

* Add formatting for toml files

* Update call to taplo

* Add command to format and a command to check

* chore(deps): Update env_logger requirement from 0.10.0 to 0.11.0 (#170)

Updates the requirements on [env_logger](https://github.com/rust-cli/env_logger) to permit the latest version.
- [Release notes](https://github.com/rust-cli/env_logger/releases)
- [Changelog](https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rust-cli/env_logger/compare/v0.10.0...v0.10.2)

---
updated-dependencies:
- dependency-name: env_logger
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: init file writer interface (#168)

* init file writer interface

* refine

---------

Co-authored-by: ZENOTME <[email protected]>

* fix: Manifest parsing should consider schema evolution. (#171)

* fix: Manifest parsing should consider schema evolution.

* Fix ut

* docs: Add release guide for iceberg-rust (#147)

* fix: Ignore negative statistics value (#173)

* feat: Add user guide for website. (#178)

* Add

* Fix format

* Add license header

* chore(deps): Update derive_builder requirement from 0.12.0 to 0.13.0 (#175)

Updates the requirements on [derive_builder](https://github.com/colin-kiegel/rust-derive-builder) to permit the latest version.
- [Release notes](https://github.com/colin-kiegel/rust-derive-builder/releases)
- [Commits](https://github.com/colin-kiegel/rust-derive-builder/compare/v0.12.0...v0.12.0)

---
updated-dependencies:
- dependency-name: derive_builder
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Replace unwrap (#183)

* feat: add handwritten serialize (#185)

* add handwritten serialize

* revert expect

* remove expect

* Fix avro schema names for manifest and manifest_list (#182)

Co-authored-by: Fokko Driesprong <[email protected]>

* feat: Bump hive_metastore to use pure rust thrift impl `volo` (#174)

* feat: Bump version 0.2.0 to prepare for release. (#181)

* feat: Bump version 0.2.0 to prepare for release.

* Update dependencies

* fix: `default_partition_spec` using the `partion_spec_id` set (#190)

* add unit tests

* fix type

* Docs: Add required Cargo version to install guide (#191)

* chore(deps): Update opendal requirement from 0.44 to 0.45 (#195)

Updates the requirements on [opendal](https://github.com/apache/opendal) to permit the latest version.
- [Release notes](https://github.com/apache/opendal/releases)
- [Changelog](https://github.com/apache/opendal/blob/main/CHANGELOG.md)
- [Commits](https://github.com/apache/opendal/compare/v0.44.0...v0.44.2)

---
updated-dependencies:
- dependency-name: opendal
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Smooth out release steps (#197)

Couple of small things:

- The license check failed because the `dist/*` files were there
- Add `dist/*` to gitignore since we don't want to push these files to the repo
- Make `scripts/release.sh` executable
- Align the svn structure with PyIceberg and Java

* refactor: remove support of manifest list format as a list of file path (#201)

* refactor: remove support of manifest list format as a list of file paths#158

* refactor: add field definition to manifest list

* refactor: delete duplicated function

* refactor: fix duplicate function name

* refactor: remove unwraps (#196)

* remove avro unwraps

* rm unwrap in schema manifest

* rm some expects

* rm types

* fix clippy

* fix string format

* refine some unwrap

* undo schema.rs

* Fix: add required rust version in cargo.toml (#193)

* Fix: add required rust version in cargo.toml

* added rust-version to workspace=true in package

* Fix the REST spec version (#198)

This number indicates from which release the code was generated.
For example, currently new endpoints are added to the spec, but
they are not supported by iceberg-rust yet.

* feat: Add Sync + Send to Catalog trait (#202)

* feat: Make thrift transport configurable (#194)

* feat: make transport configurable (#188)

* implement default for HmsThriftTransport

* Add UnboundSortOrder (#115)

* Add UnboundSortOrder

* Separate build methods for bound and unbound

* Use a constant for unsorted order_id

* ci: Add workflow for publish (#218)

* ci: Add workflow for publish

Signed-off-by: Xuanwo <[email protected]>

* Fix publish

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* ci: add workflow for cargo audit (#217)

* docs: Add basic README for all crates (#215)

* docs: Add basic README for all crates

Signed-off-by: Xuanwo <[email protected]>

* Remove license

Signed-off-by: Xuanwo <[email protected]>

* Update links

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* Follow naming convention from Iceberg's Java and Python implementations (#204)

* doc: Add download page (#219)

* doc: Add download page

* Fix links

* chore(deps): Update derive_builder requirement from 0.13.0 to 0.20.0 (#203)

Updates the requirements on [derive_builder](https://github.com/colin-kiegel/rust-derive-builder) to permit the latest version.
- [Release notes](https://github.com/colin-kiegel/rust-derive-builder/releases)
- [Commits](https://github.com/colin-kiegel/rust-derive-builder/compare/v0.13.0...v0.13.1)

---
updated-dependencies:
- dependency-name: derive_builder
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: add FileIO s3 test (#220)

* add file io s3 test

* add license

* fixed version & rm port scanner

* ci: Ignore RUSTSEC-2023-0071 for no actions to take (#222)

* ci: Ignore RUSTSEC-2023-0071 for no actions to take

Signed-off-by: Xuanwo <[email protected]>

* Fix license header

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* feat: Add expression builder and display. (#169)

* feat: Add expression builder and display.

* Fix comments

* Fix doc test

* Fix name of op

* Fix comments

* Fix timestamp

* chord:  Add IssueNavigationLink for RustRover (#230)

* chord:  IssueNavigationLink for RustRover

* move to .idea

* add apache license

---------

Co-authored-by: fuqijun <[email protected]>

* minor: Fix `double` API doc typo (#226)

* feat: add `UnboundPredicate::negate()` (#228)

Issue: #150

* fix: Remove deprecated methods to pass ci (#234)

* Implement basic Parquet data file reading capability (#207)

* feat: TableScan parquet file read to RecordBatch stream

* chore: add inline hinting and fix incorrect comment

* refactor: extract record batch reader

* refactor: rename `FileRecordBatchReader` to `ArrowReader`

* refactor: rename file_record_batch_reader.rs to arrow.rs
* refactor: move `batch_size` param to `TableScanBuilder`
* refactor: rename `TableScan.execute` to `to_arrow`

* refactor: use builder pattern to create `ArrowReader`

* chore: doc-test as a target (#235)

* feat: add parquet writer (#176)

* Add hive metastore catalog support (part 1/2) (#237)

* fmt members

* setup basic test-infra for hms-catalog

* add license

* add hms create_namespace

* add hms get_namespace

* fix: typo

* add hms namespace_exists and drop_namespace

* add hms update_namespace

* move fns into HmsCatalog

* use `expose` in docker-compose

* add hms list_tables

* fix: clippy

* fix: cargo sort

* fix: cargo workspace

* move fns into utils + add constants

* include database name in error msg

* add pilota to cargo workspace

* add minio version

* change visibility to pub(crate); return namespace from conversion fn

* add minio version in rest-catalog docker-compose

* fix: hms test docker infrastructure

* add version to minio/mc

* fix: license header

* fix: core-site

---------

Co-authored-by: mlanhenke <[email protected]>

* chore: Enable projects. (#247)

* Make plan_files as asynchronous stream (#243)

* feat: Implement binding expression (#231)

* feat: Implement binding expression

* Implement Display instead of ToString (#256)

* add rewrite_not (#263)

* feat: init TableMetadataBuilder (#262)

* Rename stat_table to table_exists in Catalog trait (#257)

* feat (static table): implement a read-only table struct loaded from metadata (#259)

* fixing some broken branch

* adding readonly property to Table, and setting readonly value on StaticTable

* feat: implement OAuth for catalog rest client (#254)

* docs: annotate precision and length to primitive types (#270)

Signed-off-by: Ruihang Xia <[email protected]>

* build: Restore CI by making parquet and arrow version consistent (#280)

* Metadata Serde + default partition_specs and sort_orders (#272)

* change serde metadata v2

* change default partition_specs and sort_orders

* change test

* use DEFAULTS

* feat: make optional oauth param configurable (#278)

* make optional oauth param configurable

* fix review comments.

---------

Co-authored-by: hpal <[email protected]>

* fix: enable public access to ManifestEntry properties (#284)

* enable public access to ManifestEntry properties

* implementing getter methods instead of direct access

* feat: Implement the conversion from Arrow Schema to Iceberg Schema (#258)

* feat: Implement the conversion from ArrowSchema to iceberg Schema

* For review

* Update test

* Add LargeString, LargeBinary, LargeList and FixedSizeList

* Add decimal type

* For review

* Fix clippy

* Rename funtion name to add_manifests (#293)

* feat: modify `Bind` calls so that they don't consume `self` and instead return a new struct, leaving the original unmoved" (#290)

* Add hive metastore catalog support (part 2/2) (#285)

* fmt members

* setup basic test-infra for hms-catalog

* add license

* add hms create_namespace

* add hms get_namespace

* fix: typo

* add hms namespace_exists and drop_namespace

* add hms update_namespace

* move fns into HmsCatalog

* use `expose` in docker-compose

* add hms list_tables

* fix: clippy

* fix: cargo sort

* fix: cargo workspace

* move fns into utils + add constants

* include database name in error msg

* add pilota to cargo workspace

* add minio version

* change visibility to pub(crate); return namespace from conversion fn

* add minio version in rest-catalog docker-compose

* fix: hms test docker infrastructure

* add version to minio/mc

* fix: license header

* fix: core-site

* split utils and errors

* add fn get_default_table_location

* add fn get_metadata_location

* add docs

* add HiveSchemaBuilder

* add schema to HiveSchemaBuilder

* add convert_to_hive_table

* cargo sort

* implement table_ops without TableMetadataBuilder

* refactor: HiveSchema fn from_iceberg

* prepare table creation without metadata

* simplify HiveSchemaBuilder

* refactor: use ok_or_else()

* simplify HiveSchemaBuilder

* fix visibility of consts

* change serde metadata v2

* change default partition_specs and sort_orders

* change test

* add create table with metadata

* use FileIO::from_path

* add test_load_table

* small fixes + docs

* rename

* extract get_metadata_location from hive_table

* add integration tests

* fix: clippy

* remove whitespace

* fix: fixture names

* remove builder-prefix `with`

* capitalize error msg

* remove trait bound `Display`

* add const `OWNER`

* fix: default warehouse location

* add test-case `list_tables`

* add all primitives to test_schema

* exclude `Timestamptz` from hive conversion

* remove Self::T from schema

* remove context

* keep file_io in HmsCatalog

* use json schema repr

---------

Co-authored-by: mlanhenke <[email protected]>

* feat: implement prune column for schema (#261)

* feat: implement PruneColumn for Schema

* fix: fix bugs for PruneColumn implementation

* test: add test cases for PruneColumn

* fix: fix minor to make more rusty

* fix: fix cargo clippy

* fix: construct expected_type from SchemaBuilder

* fix: more readability

* change return type of prune_column

* chore(deps): Update reqwest requirement from ^0.11 to ^0.12 (#296)

* Glue Catalog: Basic Setup + Test Infra (1/3) (#294)

* extend dependency DIRS

* create dependencies for glue

* basic setup

* rename test

* add utils/get_sdk_config

* add tests

* add list_namespace

* fix: clippy

* fix: unused

* fix: workspace

* fix: name

* use creds in test-setup

* fix: empty dependencies.rust.tsv

* fix: rename endpoint_url

* remove deps.tsv

* add hms deps.tsv

* fix deps.tsv

* fix: deps.tsv

* feat: rest client respect prefix prop (#297)

* feat: rest client respect prefix prop

Signed-off-by: TennyZhuang <[email protected]>

* add test

Signed-off-by: TennyZhuang <[email protected]>

* fix tests without prefix

Signed-off-by: TennyZhuang <[email protected]>

* fix clippy

Signed-off-by: TennyZhuang <[email protected]>

---------

Signed-off-by: TennyZhuang <[email protected]>

* fix: missing properties (#303)

* fix: renaming FileScanTask.data_file to data_manifest_entry (#300)

* renaming FileScanTask.data_file to data_manifest_entry

* renaming data_file.content() to content_type()

* changing pub method to data()

* feat: Make OAuth token server configurable (#305)

* feat: Glue Catalog - namespace operations (2/3) (#304)

* add from_build_error

* impl create_namespace

* impl get_namespace

* add macro with_catalog_id

* impl namespace_exists

* impl update_namespace

* impl list_tables

* impl drop_namespace

* fix: clippy

* update docs

* update docs

* fix: naming and visibility of error conversions

* feat: add transform_literal (#287)

* add transform_literal

* refine

* fix unwrap

---------

Co-authored-by: ZENOTME <[email protected]>

* feat: Complete predicate builders for all operators. (#276)

* feat: Complete predicate builders for all operators.

* ci: fix fmt error

* fix nan and notnan

* feat: Support customized header in Rest catalog client (#306)

Note that: the default headers will not be overwritten.

* fix: chrono dep (#274)

* feat: Read Parquet data file with projection (#245)

* feat: Read Parquet data file with projection

* fix

* Update

* More

* For review

* Use FeatureUnsupported error.

* Fix day timestamp micro (#312)

* basic fix

* change to Result<i32>

* use try_unary

* feat: support uri redirect in rest client (#310)

Signed-off-by: TennyZhuang <[email protected]>

* refine: seperate parquet reader and arrow convert (#313)

* Upgrade to rust-version 1.77.1 (#316)

* Support identifier warehouses (#308)

* Support identifier warehouses

This is a bit confusing if you come from a Hive background
where the warehouse is always a path to hdfs/s3/etc.

With the REST catalog, the warehouse can also be a logical
identifier:
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L72-L78

This means that we have to make sure that we only parse paths
that are an actual path, and not an identifier.

I'm open to suggestions. The check is now very simple, but can
be extended for example using a regex. But I'm not sure what
the implications are of importing additional packages (in Python
you want to keep it as lightweight as possible).

* Use `if Url::parse().is_ok()`

* feat: Project transform (#309)

* add project bucket_unary

* add project bucket_binary

* add project bucket_set

* add project identity

* add project truncate

* fixed array boundary

* add project void

* add project unknown

* add docs + none projections

* docs

* docs

* remove trait + impl boundary on Datum

* fix: clippy

* fix: test Transform::Unknown

* add: transform_literal_result

* add: transform_literal_result

* remove: whitespace

* move `boundary` to transform.rs

* add check if transform can be applied to data_type

* add check

* add: java-testsuite Transform::Bucket

* fix: clippy

* add: timestamps to boundary

* change: return bool from can_transform

* fix: clippy

* refactor: fn project match structure

* add: java-testsuite Transform::Truncate

* add: java-testsuite Transform::Dates + refactor

* fix: doc

* add: timestamp test + refactor

* refactor: simplify projected_boundary

* add: java-testsuite Transform::Timestamp

* refactor tests

* fix: timestamp conversion

* fix: temporal test_result

* basic fix

* change to Result<i32>

* use try_unary

* add: java-testsuite Transform::Timestamp Hours

* refactor: split and move tests

* refactor: move transform tests

* remove self

* refactor: structure fn project + helpers

* fix: clippy

* fix: typo

* fix: naming + generics

* feat: add Struct Accessors to BoundReferences (#317)

* feat: use str args rather than String in transform (#325)

* chore(deps): Update pilota requirement from 0.10.0 to 0.11.0 (#327)

Updates the requirements on [pilota](https://github.com/cloudwego/pilota) to permit the latest version.
- [Release notes](https://github.com/cloudwego/pilota/releases)
- [Commits](https://github.com/cloudwego/pilota/compare/pilota-0.10.0...pilota-0.10.0)

---
updated-dependencies:
- dependency-name: pilota
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump peaceiris/actions-mdbook from 1 to 2 (#332)

Bumps [peaceiris/actions-mdbook](https://github.com/peaceiris/actions-mdbook) from 1 to 2.
- [Release notes](https://github.com/peaceiris/actions-mdbook/releases)
- [Changelog](https://github.com/peaceiris/actions-mdbook/blob/main/CHANGELOG.md)
- [Commits](https://github.com/peaceiris/actions-mdbook/compare/v1...v2)

---
updated-dependencies:
- dependency-name: peaceiris/actions-mdbook
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump peaceiris/actions-gh-pages from 3.9.3 to 4.0.0 (#333)

Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.3 to 4.0.0.
- [Release notes](https://github.com/peaceiris/actions-gh-pages/releases)
- [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md)
- [Commits](https://github.com/peaceiris/actions-gh-pages/compare/v3.9.3...v4.0.0)

---
updated-dependencies:
- dependency-name: peaceiris/actions-gh-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump apache/skywalking-eyes from 0.5.0 to 0.6.0 (#328)

Bumps [apache/skywalking-eyes](https://github.com/apache/skywalking-eyes) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/apache/skywalking-eyes/releases)
- [Changelog](https://github.com/apache/skywalking-eyes/blob/main/CHANGES.md)
- [Commits](https://github.com/apache/skywalking-eyes/compare/v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: apache/skywalking-eyes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add BoundPredicateVisitor. Add AlwaysTrue and AlwaysFalse to Predicate (#334)

* feat: add InclusiveProjection (#335)

* feat: Implement the conversion from Iceberg Schema to Arrow Schema (#277)

* support iceberg schema to arrow schema

* avoid realloc hashmap

---------

Co-authored-by: ZENOTME <[email protected]>

* Simplify expression when doing `{and,or}` operations (#339)

This will make sure that we nicely reduce the expression in
the inclusive projection visitor:

https://github.com/apache/iceberg-rust/blob/de80a2436bb2fbbd5b4ec6bcafd0bd041b263595/crates/iceberg/src/expr/visitors/inclusive_projection.rs#L73

* feat: Glue Catalog - table operations (3/3) (#314)

* add GlueSchemaBuilder

* add warehouse

* add serde_json, tokio, uuid

* add minio

* add create_table

* add tests utils

* add load_table

* add drop_table + table_exists

* add rename_table

* add docs

* fix: docs + err_msg

* fix: remove unused const

* fix: default_table_location

* fix: remove single quotes error message

* chore: add test-condition `test_rename_table`

* chore: add test-condition `test_table_exists`

* chore: update roadmap (#336)

* chore: update roadmap

* chore: update reader section

* fix: read into arrow record batch

* feat: add ManifestEvaluator (#322)

* feat: init iceberg writer (#275)

* init iceberg writer

* refine

* refine the interface

---------

Co-authored-by: ZENOTME <[email protected]>

* feat: implement manifest filtering in TableScan (#323)

* Refactor: Extract `partition_filters` from `ManifestEvaluator` (#360)

* refactor: extract inclusive_projection from manifest_evaluator

* refactor: add FileScanStreamContext

* refactor: create partition_spec and partition_schema

* refactor: add cache structs

* refactor: use entry in partition_file_cache

* refactor: use result

* chore: update docs + fmt

* refactor: add bound_filter to FileScanStreamContext

* refactor: return ref BoundPredicate

* fix: return type PartitionSpecRef

* refactor: remove spec_id runtime check

* feat: add check for content_type data

* Basic Integration with Datafusion (#324)

* chore: basic structure

* feat: add IcebergCatalogProvider

* feat: add IcebergSchemaProvider

* feat: add IcebergTableProvider

* chore: add integration test infr

* fix: remove old test

* chore: update crate structure

* fix: remove workspace dep

* refactor: use try_join_all

* chore: remove feature flag

* chore: rename package

* chore: update readme

* feat: add TableType

* fix: import + async_trait

* fix: imports + async_trait

* chore: remove feature flag

* fix: cargo sort

* refactor: CatalogProvider `fn try_new`

* refactor: SchemaProvider `fn try_new`

* chore: update docs

* chore: update docs

* chore: update doc

* feat: impl `fn schema` on TableProvider

* chore: rename ArrowSchema

* refactor: remove DashMap

* feat: add basic IcebergTableScan

* chore: fix docs

* chore: add comments

* fix: clippy

* fix: typo

* fix: license

* chore: update docs

* chore: move derive stmt

* fix: collect into hashmap

* chore: use DFResult

* Update crates/integrations/datafusion/README.md

Co-authored-by: Liang-Chi Hsieh <[email protected]>

---------

Co-authored-by: Renjie Liu <[email protected]>
Co-authored-by: Liang-Chi Hsieh <[email protected]>

* refactor: cache partition_schema in `fn plan_files()` (#362)

* refactor: add partition_schema_cache

* refactor: use context as param object

* fix: test setup

* refactor: clone only when cache miss

* chore: move derive stmts

* refactor: remove unused case_sensitive parameter

* refactor: remove partition_schema_cache

* refactor: move partition_filter into wider scope

* fix (manifest-list): added serde aliases to support both forms conventions (#365)

* added serde aliases to support both forms conventions

* reading manifests without avro schema

* adding avro files of both versions and add a test to deser both

* fixed typo

* feat: Extract FileRead and FileWrite trait (#364)

* feat: Extract FileRead and FileWrie trait

Signed-off-by: Xuanwo <[email protected]>

* Enable s3 services for tests

Signed-off-by: Xuanwo <[email protected]>

* Fix sort

Signed-off-by: Xuanwo <[email protected]>

* Add comment for io trait

Signed-off-by: Xuanwo <[email protected]>

* Fix test for rest

Signed-off-by: Xuanwo <[email protected]>

* Use try join

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* feat: Convert predicate to arrow filter and push down to parquet reader (#295)

* feat: Convert predicate to arrow filter and push down to parquet reader

* For review

* Fix clippy

* Change from vector of BoundPredicate to BoundPredicate

* Add test for CollectFieldIdVisitor

* Return projection_mask for leaf column

* Update

* For review

* For review

* For review

* For review

* More

* fix

* Fix clippy

* More

* Fix clippy

* fix clippy

* chore(deps): Update datafusion requirement from 37.0.0 to 38.0.0 (#369)

* chore(deps): Update itertools requirement from 0.12 to 0.13 (#376)

* Add `InclusiveMetricsEvaluator` (#347)

* feat: add InclusiveMetricsEvaluator

* test: add more tests for InclusiveMetricsEvaluator

* Rename V2 spec names. (#380)

* make file scan task serializable (#377)

Co-authored-by: ZENOTME <[email protected]>

* Feature: Schema into_builder method (#381)

* replaced `i32` in `TableUpdate::SetDefaultSortOrder` to `i64` (#387)

* fix: make PrimitiveLiteral and Literal not be Ord (#386)

* make PrimitiveLiteral and Literal not be Ord

* refine Map

* fix name

* fix map test

* refine

---------

Co-authored-by: ZENOTME <[email protected]>

* docs(writer/docker): fix small typos and wording (#389)

* docs: fixup docker compose test_utils

* docs: iceberg writer close fn

* feat: `StructAccessor.get` returns `Result<Option<Datum>>` instead of `Result<Datum>` (#390)

This is so that the accessor's result can represent null field values.

Fixes: #379

* feat: add `ExpressionEvaluator` (#363)

* refactor: add partition_schema_cache

* refactor: use context as param object

* fix: test setup

* refactor: clone only when cache miss

* chore: move derive stmts

* feat: add basic setup expression evaluator

* refactor: remove unused case_sensitive parameter

* chore: add doc

* refactor: remove partition_schema_cache

* refactor: move partition_filter into wider scope

* feat: add expression_evaluator_cache and apply in scan.rs

* chore: remove comment

* refactor: remove unused test setup fn

* feat: add basic test infr + simple predicate evaluation

* fix: clippy

* feat: impl `is_null` + `not_null`

* feat: impl `is_nan` + `not_nan`

* chore: change result type

* feat: impl `less_than` + `greater_than`

* chore: fix return type

* feat: impl `eq` + `not_eq`

* feat: impl `starts_with + `not_starts_with`

* feat: impl  +

* chore: add tests for and and or expr

* chore: move test

* chore: remove unused_vars

* chore: update docs

* chore: update docs

* fix: typo

* refactor: compare datum instead of primitive literal

* refactor: use Result<Option> from accessor

* chore: remove unused fn

* fix: sdd sleep pattern matching

* Derive Clone for TableUpdate (#402)

* Add accessor for Schema identifier_field_ids (#388)

* Add accessor for Schema identifier_field_ids

* dont expose HashSet

Co-authored-by: Renjie Liu <[email protected]>

* fix

* Fix accessor

---------

Co-authored-by: Renjie Liu <[email protected]>

* deps: Bump arrow related crates to 52 (#403)

* SnapshotRetention::Tag max_ref_age_ms should be optional (#391)

* feat: Add storage features for iceberg (#400)

* feat: Add storage features for iceberg

Signed-off-by: Xuanwo <[email protected]>

* Format toml

Signed-off-by: Xuanwo <[email protected]>

* Add fs and s3 into default features

Signed-off-by: Xuanwo <[email protected]>

* Make toml happy

Signed-off-by: Xuanwo <[email protected]>

* Remove not needed feature flag

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* Implement `BoundPredicateVisitor` for `ManifestFilterVisitor` (#367)

* Implement all functions of BoundPredicateVisitor for ManifestFilterVisitor

* Fix code comments

* Refactor code and fixpredicate for is_some_and

* Refactor code

* Handle review comments

* Handle review comments

* Handle review comments

* Refactor code

* Add missing arrow predicate pushdown implementations for `StartsWith`, `NotStartsWith`, `In`, and `NotIn` (#404)

* feat: add [not_]starts_with and [not_]in arrow predicate pushdown

* fixes from issues highlighted in review

* feat: make BoundPredicate,Datum serializable (#406)

* make BoundPredicate,Datum serializable

* refine error

* fix float check

* use value instead of string to avoid precision loss

---------

Co-authored-by: ZENOTME <[email protected]>

* refactor: Upgrade hive_metastore to 0.1 (#409)

* refactor: Upgrade hive_metastore to 0.1

Signed-off-by: Xuanwo <[email protected]>

* format toml

Signed-off-by: Xuanwo <[email protected]>

* Fix typo

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* Remove duplicate filter (#414)

* Enhancement: refine the reader interface (#401)

* refactor(catalog/rest): Split http client logic to seperate mod (#423)

Signed-off-by: Xuanwo <[email protected]>

* Remove #[allow(dead_code)] from the codebase (#421)

* Remove #[allow(dead_code)] from the codebase

* Remove: dead_code, move: avroschema fn to test

* Fix checks and code style, remove unused code

* Change function name

* ci: use official typos github action (#426)

* feat: support lower_bound&&upper_bound for parquet writer (#383)

* refactor: Implement ArrowAsyncFileWriter directly to remove tokio (#427)

* refactor: Implement ArrowAsyncFileWriter directly to remove tokio

Signed-off-by: Xuanwo <[email protected]>

* Make build pass

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* chore: Don't enable reqwest default features (#432)

* refactor(catalogs/rest): Split user config and runtime config (#431)

* refactor(catalogs/rest): Split user config and runtime config

Signed-off-by: Xuanwo <[email protected]>

* Sort cargo

Signed-off-by: Xuanwo <[email protected]>

* Fix unit tests

Signed-off-by: Xuanwo <[email protected]>

* Remove default feature of tokio

Signed-off-by: Xuanwo <[email protected]>

* return error here

Signed-off-by: Xuanwo <[email protected]>

* Return error if cred doesn't exist

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* feat: runtime module (#233)

* temp runtime

* POC

* fix chrono

* fix dep

* refine module

* refactor to use a deadly simple way

* allow dead_code

* add license

* fix clippy and tests

* clean code

* undo

* add async-std ci test

* rm tokio dev-dep

* make tokio dev dep

* fix sort

* rm tokio dev

* fix: Fix namespace identifier in url (#435)

* fix: Fix namespace identifier in url

* Remove table encoding

* refactor(io): Split io into smaller mods (#438)

* refactor(io): Split io into smaller mods

Signed-off-by: Xuanwo <[email protected]>

* Fix test

Signed-off-by: Xuanwo <[email protected]>

* Format

Signed-off-by: Xuanwo <[email protected]>

* Fix cap

Signed-off-by: Xuanwo <[email protected]>

* Remove not used deps

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* chore: Use once_cell to replace lazy_static (#443)

* chore: Use once_cell to replace lazy_static

Signed-off-by: Xuanwo <[email protected]>

* Format toml

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* fix: Fix build while no-default-features enabled (#442)

* fix: Fix build while no-default-features enabled

Signed-off-by: Xuanwo <[email protected]>

* Fix clippy

Signed-off-by: Xuanwo <[email protected]>

* Add ci for no default features

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* chore(deps): Bump crate-ci/typos from 1.22.9 to 1.23.1 (#447)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](https://github.com/crate-ci/typos/compare/v1.22.9...v1.23.1)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: Refactor the README to be more user-oriented (#444)

* docs: Refactor the README to be more user-oriented

Signed-off-by: Xuanwo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Fokko Driesprong <[email protected]>

* Polish

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>

* feat: Add cargo machete (#448)

* adding cargo machete to check unused dependencies

* remove default values

* adding a tag version instead of main

* running cargo machete natively

* removing unused dependency urlencoding

* bug fixes

* chore: Use nightly toolchain for check (#445)

* chore: Use nightly toolchain for check

* Fix check

* Fix clippy finds

* Make rustfmt happy

* Make rustfmt happy

* Update github actions

* Use action builder since apache doesn't allow external actions

* Fix comments

* Fix README.md

* reuse docker container to save compute resources (#428)

* reuse docker container to save compute resources

* add lazy resuse docker compose

* refactor test fixture: the docker compose init is reused

* use ctor and dtor to start docker compose and destory docker compose

* fix cargo fmt check

* fix cargo clippy

* fix cargo fmt

* fix cargo sort

* add namespace for datafusion test

* add empty check for list glue catalog namespace

---------

Co-authored-by: thexiay <[email protected]>

* feat: Add macos runner for ci (#441)

* feat: Add macos runner for ci

* feat: Add publish for macOS

* reset the publish.yml

* feat: add macOS for check ci

* remove the macOS for unit ci

* chore: remove compose obsolete version (#452) (#454)

reference: https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-obsolete

* Refactor file_io_s3_test.rs (#455)

* chore(deps): Bump crate-ci/typos from 1.23.1 to 1.23.2 (#457)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.1 to 1.23.2.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](https://github.com/crate-ci/typos/compare/v1.23.1...v1.23.2)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* remove binary serialize in literal (#456)

Co-authored-by: ZENOTME <[email protected]>

* fix: Hms test on macos should use correct arch (#461)

* Fix ManifestFile length calculation (#466)

* chore(deps): Update typed-builder requirement from ^0.18 to ^0.19 (#473)

---
updated-dependencies:
- dependency-name: typed-builder
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: use avro fixed to represent decimal (#472)

fix #144

Signed-off-by: xxchan <[email protected]>

* chore(catalog): Deprecate rest.authorization-url in favor of oauth2-server-uri (#480)

* fix: Transform::Day maps to Date rather than Int for consistency with reference implementation (#479)

Issue: https://github.com/apache/iceberg-rust/issues/478

* feat(iceberg): Add memory file IO support (#481)

* feat(iceberg): Add memory file IO support

Signed-off-by: Xuanwo <[email protected]>

* Fix typo

Signed-off-by: Xuanwo <[email protected]>

* Add comments for memory file io

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* Add in-memory catalog implementation (#475)

* feat: Add in-memory catalog

* Make clippy happy

* Make cargo sort happy

* Fix README links

* Configurable file_io

* Avoid nightly features

* Remove TempFile

* Use futures::lock::Mutex instead

* Minor clean up

* Make root configurable in FS FileIO and remove default_table_root_location from Catalog

* Revert "Make root configurable in FS FileIO and remove default_table_root_location from Catalog"

This reverts commit 807dd4cf649b5c367f25afc59f99341d6995c337.

* Remove default_table_root_location from Catalog and explicitly configure a location for tables in unit tests

* lowercase catalog

* Use default instead of new

* Change references to memory

* chore: Enable new rust code format settings (#483)

* chore: Enable new format settings

Signed-off-by: Xuanwo <[email protected]>

* Format

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* docs: Generate rust API docs (#486)

Signed-off-by: Xuanwo <[email protected]>

* chore: Fix format of recent PRs (#487)

Signed-off-by: Xuanwo <[email protected]>

* Rename folder to memory (#490)

* chore(deps): Bump crate-ci/typos from 1.23.2 to 1.23.5 (#493)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.2 to 1.23.5.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](https://github.com/crate-ci/typos/compare/v1.23.2...v1.23.5)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* View Spec implementation (#331)

* Add support for ViewSpec

* Fix typos

* Fix typos

* clippy is always right

* Add tests

* Remove new_view_version test function

* Remove append_version

* View Representations Struct

* ViewRepresentation case insensitive

* Add fallible methods for ViewRepresentationsBuilder

* Add tests for fallibe ViewRepresentationsBuilder methods

* Introduce ViewVersionId as i32

* Iterator for &'a ViewRepresentations

* Improve comments

Co-authored-by: Renjie Liu <[email protected]>

* Add test_view_metadata_v1_file_valid

* Fix view_version iter

* Remove ViewRepresentationsBuilder

* Fix comment

* Timestamp error handling

* Fallible Timestamp Conversion from Millis

* Fix Initial view Version = 1

* Cleanup

* Hide ViewMetadata iter() type

* timestamp_ms_to_utc -> error.rs

* TableMetadata timestamp conversion -> utility function

* Improve error context

* timestamp_ms_to_utc: LocalResult::None -> DataInvalid

* Fix obsolete comment

* ViewRepresentation::SqlViewRepresentation -> ::Sql

* Fix broken clippy from rebase

---------

Co-authored-by: Renjie Liu <[email protected]>

* fix: Return error on reader task (#498)

* chore: Bump OpenDAL to 0.48 (#500)

* chore: Bump OpenDAL to 0.48

Signed-off-by: Xuanwo <[email protected]>

* Format toml

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* add check compatible func for primitive type (#492)

Co-authored-by: ZENOTME <[email protected]>

* refactor(iceberg): Remove an extra config parse logic (#499)

* refactor(iceberg): Remove an extra config parse logic

Signed-off-by: Xuanwo <[email protected]>

* Format toml

Signed-off-by: Xuanwo <[email protected]>

* reduce some allocs

Signed-off-by: Xuanwo <[email protected]>

* Cleanup more

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* feat: permit Datum Date<->Int type conversion (#496)

Required for correct handling of partitions with Transform::Date

* Add additional S3 FileIO Attributes (#505)

* Add additional S3 FileIO Attributes

* Remove custom S3SSEType

* docs: Add links to dev docs (#508)

* docs: Add links to dev docs

Signed-off-by: Xuanwo <[email protected]>

* Add links

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* chore: Remove typo in README (#509)

* chore: Remove typo in README

Signed-off-by: Xuanwo <[email protected]>

* Fix link

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* feat: podman support (#489)

* feat: improve docker/podman get OsArch compatibility

* fix: replace deprecated 'links' keyword in docker compose

* refactor: use IpAddr and SocketAddr when able

* docs: add podman documentation

* address PR documentation comments

* address pr comments on tests

* Address pr comments, properly handle result with match

* address pr comments, refactor get_cmd_output

* move podman instr to docs/contributing

* address pr comment, show detailed err msg

---------

Co-authored-by: Alex Yin <[email protected]>

* feat(table): Add debug and clone trait to static table struct (#510)

* Use namespace location or warehouse location if table location is missing (#511)

* chore(deps): Bump crate-ci/typos from 1.23.5 to 1.23.6 (#521)

* Concurrent table scans (#373)

* feat: concurrent table scans

* refactor: remove TableScanConfig.

* refactor: replace num_cpus with thread::available_parallelism (#526)

* Fix: MappedLocalTime should not be exposed (#529)

* feat: Establish subproject pyiceberg_core (#518)

Signed-off-by: Xuanwo <[email protected]>

* fix: complete miss attribute for map && list in avro schema (#411)

* add miss attr in list/map avro schema

* refine error handle

* fix unused warn

* fix typos

* update avro and unittest

* refine check_schema_conversion

---------

Co-authored-by: ZENOTME <[email protected]>

* arrow/schema.rs: refactor tests (#531)

* arrow/schema.rs: refactor tests

Signed-off-by: Shirly <[email protected]>

* *:address comments

Signed-off-by: Shirly <[email protected]>

---------

Signed-off-by: Shirly <[email protected]>

* feat: initialise SQL Catalog (#524)

* feat: initialise SQL Catalog

Signed-off-by: callum-ryan <[email protected]>

* fix: remove rls-rustls

Signed-off-by: callum-ryan <[email protected]>

* feat: change to SqlBindStyle and rename consts

Signed-off-by: callum-ryan <[email protected]>

---------

Signed-off-by: callum-ryan <[email protected]>

* chore(deps): Bump actions/setup-python from 4 to 5 (#536)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* support session token (#530)

* Simplify PrimitiveLiteral (#502)

* simplify PrimitiveLiteral

* fix test

---------

Co-authored-by: ZENOTME <[email protected]>

* chore: bump opendal to 0.49 (#540)

* feat: support timestamp columns in row filters (#533)

Fixes: https://github.com/apache/iceberg-rust/issues/532

* fix: don't silently drop errors encountered in table scan file planning (#535)

* chore(deps): Update sqlx requirement from 0.7.4 to 0.8.0 (#537)

Updates the requirements on [sqlx](https://github.com/launchbadge/sqlx) to permit the latest version.
- [Changelog](https://github.com/launchbadge/sqlx/blob/main/CHANGELOG.md)
- [Commits](https://github.com/launchbadge/sqlx/compare/v0.7.4...v0.8.0)

---
updated-dependencies:
- dependency-name: sqlx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix main branch building break (#541)

* feat: support for gcs storage (#520)

* chore: include opendal/services-gcs

* feat: basic gcs scaffolding

* feat: populate config parse with basic details

* feat: include docker-compose integration tests

* feat: add extra iceberg properties

* feat: add tests for gcs read/write

These are currently conditional tests with a todo comment using the
test_with proc macro. More work needs to be done on
investigating/potentially expanding OpenDAL to allow unauthenticated
requests to fake-gcs-server. At the moment this always ends up reaching
the final VM metadata check.

* chore: minor cleanup for compose todo

* fix: do not introduce new properties

* feat: infer bucket from path

* chore: add user-project const

* feat: add allow_anonymous for test

* chore: remove test-with dep

* feat: update with allow_anonymous functionality

This requires the opendal allow_anonymous funcitonality with the GCS
service to work.

* ci: use cargo sort

* chore: undo storage-gcs default feature

* feat: include disable_ params for GCS_NO_AUTH

* ci: use storage-all for async-std tests

* revert: use opendal from workspace

Now that v0.49 has been released, this work does not need to pin to a
particular version!

* feat: Allow FileIO to reuse http client (#544)

Signed-off-by: Xuanwo <[email protected]>

* docs: Add an example to scan an iceberg table (#545)

* docs: Add an example to scan an iceberg table

Signed-off-by: Xuanwo <[email protected]>

* Format toml

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

* Concurrent data file fetching and parallel RecordBatch processing (#515)

* feat: concurrent data file fetches, parallel RecordBatch processing

* refactor: centralize infallible `available_parallelism` fn. Use better channel size limit in arrow read

* doc: Add statement for contributors to avoid force push as much as possible (#546)

* chore: Bump datafusion to 41 (#548)

Signed-off-by: Xuanwo <[email protected]>

* feat: Partition Binding and safe PartitionSpecBuilder (#491)

* Initial commit

* Fixes

* Replace UnboundPartitionSpec Builder

* Fix tests, allow year, month day partition

* Comments

* typos

* Fix UnboundBuild setting partition_id

* Add test for unbound spec without partition ids

* Fix into_unbound fn name

* Split bound & unbound Partition builder, change add_partition_fields

* Improve comment

* Fix fmt

* Review fixes

* Remove partition_names() HashSet creation

* Bump to version 0.3.0 (#549)

* Bump to version 0.3.0

Signed-off-by: Xuanwo <[email protected]>

* regen

Signed-off-by: Xuanwo <[email protected]>

* Fix typo

Signed-off-by: Xuanwo <[email protected]>

* Update CHANGELOG.md

---------

Signed-off-by: Xuanwo <[email protected]>

* io: add support for role arn and external id s3 props (#553)

Add support for client.assume-role.arn and
client.assume-role.external-id s3 config properties.

Partial fix for #527

* fix: ensure S3 and GCS integ tests are conditionally compiled only when the storage-s3 and storage-gcs features are enabled (#552)

* docs: fix main iceberg example (#554)

* io: add support to set assume role session name (#555)

Partial fix for #527

* test: refactor datafusion test with memory catalog (#557)

* add memory catalog

* fix style

* fix style

* add clean job in Makefile (#561)

* docs: Fix build website permission changed (#564)

* Object Cache: caches parsed Manifests and ManifestLists for performance (#512)

* feat: adds ObjectCache, to cache Manifests and ManifestLists

* refactor: change obj cache method names and use more readable default usize value

* chore: improve error message

Co-authored-by: Renjie Liu <[email protected]>

* fix: change object cache retrieval method visibility

Co-authored-by: Renjie Liu <[email protected]>

* feat: improved error message in object cache get_manifest

* test(object-cache): add unit tests for object cache manifest and manifest list retrieval

* fix: ensure that object cache insertions are weighted by size

* test: fix test typo

* fix: ensure object cache weight is that of the wrapped item, not the Arc

---------

Co-authored-by: Renjie Liu <[email protected]>

* Update the paths (#569)

This is in line with the paths above, and also with the previous version:

https://dist.apache.org/repos/dist/release/iceberg/

* docs: Add links for released crates (#570)

Signed-off-by: Xuanwo <[email protected]>

* Python: Use hatch for dependency management (#572)

* Ensure that RestCatalog passes user config to FileIO (#476)

* fix: ensure that RestCatalog passes user config to FileIO

* docs: added some doc comments to clarify override order for config

* Move `zlib` and `unicode` licenses to `allow` (#566)

Both licenses can be moved to the `allowed` section:

- **adler32** [ships](https://github.com/remram44/adler32-rs/blob/master/LICENSE) with a **zlib** license and is a category A-license
- **unicode-ident** ships with a **UNICODE, INC. LICENSE AGREEMENT - DATA FILES AND SOFTWARE** which is also a category A-license

The **ring** license is a bit [more involved](https://github.com/briansmith/ring/blob/main/LICENSE) and carries a lot of history, I think it is best to keep that as an exception for now, since the OpenSSL license is also not explicitly listed on the ASF page. I don't see anything alarming in the `LICENSE` file.

ASF page on the subject: https://www.apache.org/legal/resolved.html#category-a

* website: Update links for 0.3.0 (#573)

Signed-off-by: Xuanwo <[email protected]>

* feat(timestamp_ns): Implement timestamps with nanosecond precision (#542)

* feat(timestamp_ns): first commit

* feat(timestamp_ns): Add mappings for timestamp_ns/timestamptz_ns

* feat(timestamp_ns): Remove unused dep

* feat(timestamp_ns): Fix unit test

* feat(timestamp_ns): Fix test_all_type_for_write()

* feat(timestamp_ns): fix test_transform_days_literal

* feat(timestamp_ns): fix math for timestamptz_nanos

* chore: formatting

* chore: formatting

* chore: Appease clippy

---------

Co-authored-by: Timothy Maloney <[email protected]>

* fix: correct partition-id to field-id in UnboundPartitionField (#576)

* correct partition-id to field id in PartitionSpec

* correct partition-id to field id in PartitionSpec

* correct partition-id to field id in PartitionSpec

* xx

* fix: Update sqlx from 0.8.0 to 0.8.1 (#584)

* chore(deps): Update typed-builder requirement from 0.19 to 0.20 (#582)

---
updated-dependencies:
- dependency-name: typed-builder
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Expose Transforms to Python Binding (#556)

* bucket transform rust binding

* format

* poetry x maturin

* ignore poetry.lock in license check

* update bindings_python_ci to use makefile

* newline

* https://github.com/python-poetry/poetry/pull/9135

* use hatch instead of poetry

* refactor

* revert licenserc change

* adopt review feedback

* comments

* unused dependency

* adopt review comment

* newline

* I like this approach a lot better

* more tests

* chore(deps): Bump crate-ci/typos from 1.23.6 to 1.24.1 (#583)

* Table Scan: Add Row Group Skipping (#558)

* feat(scan): add row group and page index row selection filtering

* fix(row selection): off-by-one error

* feat: remove row selection to defer to a second PR

* feat: better min/max val conversion in RowGroupMetricsEvaluator

* test(row_group_filtering): first three tests

* test(row_group_filtering): next few tests

* test: add more tests for RowGroupMetricsEvaluator

* chore: refactor test assertions to silence clippy lints

* refactor: consolidate parquet stat min/max parsing in one place

* chore: bump crate-ci/typos to 1.24.3 (#598)

* feat: SQL Catalog - namespaces (#534)

* feat: SQL Catalog - namespaces

Signed-off-by: callum-ryan <[email protected]>

* feat: use transaction for updates and creates

Signed-off-by: callum-ryan <[email protected]>

* fix: pull out query param builder to fn

Signed-off-by: callum-ryan <[email protected]>

* feat: add drop and tests

Signed-off-by: callum-ryan <[email protected]>

* fix: String to str, remove pub and optimise query builder

Signed-off-by: callum-ryan <[email protected]>

* fix: nested match, remove ok()

Signed-off-by: callum-ryan <[email protected]>

* fix: remove pub, add set, add comments

Signed-off-by: callum-ryan <[email protected]>

* fix: refactor list_namespaces slightly

Signed-off-by: callum-ryan <[email protected]>

* fix: add default properties to all new namespaces

Signed-off-by: callum-ryan <[email protected]>

* fix: remove check for nested namespace

Signed-off-by: callum-ryan <[email protected]>

* chore: add more comments to the CatalogConfig to explain bind styles

Signed-off-by: callum-ryan <[email protected]>

* fix: edit test for nested namespaces

Signed-off-by: callum-ryan <[email protected]>

---------

Signed-off-by: callum-ryan <[email protected]>

* feat: Add more fields in FileScanTask (#609)

Signed-off-by: Xuanwo <[email protected]>

* chore(deps): Bump crate-ci/typos from 1.24.3 to 1.24.5 (#616)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.24.3 to 1.24.5.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](https://github.com/crate-ci/typos/compare/v1.24.3...v1.24.5)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: Less Panics for Snapshot timestamps (#614)

* feat: partition compatibility (#612)

* Partition compatability

* Partition compatability

* Rename compatible_with -> is_compatible_with

* feat: SortOrder methods should take schema ref if possible (#613)

* SortOrder methods should take schema ref if possible

* Fix test type

* with_order_id should not take reference

* feat: add `client.region` (#623)

* fix: Correctly calculate highest_field_id in schema (#590)

---------

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: Shirly <[email protected]>
Signed-off-by: callum-ryan <[email protected]>
Co-authored-by: Xuanwo <[email protected]>
Co-authored-by: Renjie Liu <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hiirrxnn <[email protected]>
Co-authored-by: Tyler Schauer <[email protected]>
Co-authored-by: ZENOTME <[email protected]>
Co-authored-by: ZENOTME <[email protected]>
Co-authored-by: Chengxu Bian <[email protected]>
Co-authored-by: JanKaul <[email protected]>
Co-authored-by: Manu Zhang <[email protected]>
Co-authored-by: Yue Deng <[email protected]>
Co-authored-by: Dinesh Phuyel <[email protected]>
Co-authored-by: ZHENGLIN LI <[email protected]>
Co-authored-by: Mark Grey <[email protected]>
Co-authored-by: Farooq Qaiser <[email protected]>
Co-authored-by: Scott Donnelly <[email protected]>
Co-authored-by: Shabana Baig <[email protected]>
Co-authored-by: stream2000 <[email protected]>
Co-authored-by: fuqijun <[email protected]>
Co-authored-by: Liang-Chi Hsieh <[email protected]>
Co-authored-by: Marvin Lanhenke <[email protected]>
Co-authored-by: mlanhenke <[email protected]>
Co-authored-by: 张林伟 <[email protected]>
Co-authored-by: Alon Agmon <[email protected]>
Co-authored-by: TennyZhuang <[email protected]>
Co-authored-by: Ruihang Xia <[email protected]>
Co-authored-by: Himadri Pal <[email protected]>
Co-authored-by: hpal <[email protected]>
Co-authored-by: Howie Wang <[email protected]>
Co-authored-by: QuakeWang <[email protected]>
Co-authored-by: Ajay Gupte <[email protected]>
Co-authored-by: Christian <[email protected]>
Co-authored-by: Matiukhin Vlad <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Christian <[email protected]>
Co-authored-by: Vivek Khatri <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
Co-authored-by: Vipul Vaibhaw <[email protected]>
Co-authored-by: thexia <[email protected]>
Co-authored-by: thexiay <[email protected]>
Co-authored-by: yinheli <[email protected]>
Co-authored-by: tom <[email protected]>
Co-authored-by: xxchan <[email protected]>
Co-authored-by: Andre Luis Anastacio <[email protected]>
Co-authored-by: Andre Luis Anastacio <[email protected]>
Co-authored-by: Alex Yin <[email protected]>
Co-authored-by: Alex Yin <[email protected]>
Co-authored-by: SteveLauC <[email protected]>
Co-authored-by: Shirly <[email protected]>
Co-authored-by: Callum Ryan <[email protected]>
Co-authored-by: Tobias Pütz <[email protected]>
Co-authored-by: Matheus Alcantara <[email protected]>
Co-authored-by: Matheus Alcantara <[email protected]>
Co-authored-by: FANNG <[email protected]>
Co-authored-by: ChinoUkaegbu <[email protected]>
Co-authored-by: Sung Yun <[email protected]>
Co-authored-by: Timothy Maloney <[email protected]>
Co-authored-by: Timothy Maloney <[email protected]>
Co-authored-by: Søren Dalby Larsen <[email protected]>
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
@viirya @shaeqahmed
feat: Convert predicate to arrow filter and push down to parquet read…
ef864ec 
…er (apache#295)

* feat: Convert predicate to arrow filter and push down to parquet reader

* For review

* Fix clippy

* Change from vector of BoundPredicate to BoundPredicate

* Add test for CollectFieldIdVisitor

* Return projection_mask for leaf column

* Update

* For review

* For review

* For review

* For review

* More

* fix

* Fix clippy

* More

* Fix clippy

* fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert row filter to arrow filter
2 participants
@viirya @liurenjie1024