Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Release Action to publish pyiceberg_core dist to Pypi #705

Merged
merged 20 commits into from
Nov 25, 2024

Conversation

sungwy
Copy link
Contributor

@sungwy sungwy commented Nov 19, 2024

Github Action to publish to PyPi and TestPypi

Test deployed artifact from my fork: https://test.pypi.org/project/pyiceberg-core/#files

@sungwy sungwy requested review from Xuanwo and Fokko November 19, 2024 14:17
@sungwy
Copy link
Contributor Author

sungwy commented Nov 19, 2024

@Fokko @Xuanwo - I put this together by referring to the opendal release_python.yml gh actions file. Could I ask for your reviews?

@Xuanwo
Copy link
Member

Xuanwo commented Nov 19, 2024

Thank you very much for this. I had plans to implement the Python binding release workflow but postponed it due to various reasons. I'm so happy that you took this on. I will review it this week.

@sungwy
Copy link
Contributor Author

sungwy commented Nov 20, 2024

@Xuanwo - no problem! This has been on my todo list as well for some time. I'm excited to get this finally out! Thank you so much for your review!

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sungwy, mostly LGTM!

.github/workflows/release_python.yml Outdated Show resolved Hide resolved
@sungwy sungwy requested a review from Xuanwo November 25, 2024 02:55
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sungwy for building this!

@Xuanwo Xuanwo merged commit 286938e into apache:main Nov 25, 2024
17 checks passed
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants