Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump upload-artifact@v3 to v4 #725

Merged
merged 11 commits into from
Nov 28, 2024
Merged

chore: Bump upload-artifact@v3 to v4 #725

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a505ba8
bump upload-artifact@v3 to v4
sungwy Nov 27, 2024
e57dfec
set pyiceberg_core version to 0.1.0
sungwy Nov 27, 2024
1287a6d
fix
sungwy Nov 27, 2024
9e96f82
test publishing to pypi
sungwy Nov 27, 2024
4294cf0
fix
sungwy Nov 27, 2024
31058a0
fix
sungwy Nov 27, 2024
6157b41
fix
sungwy Nov 27, 2024
abc8d0d
use pattern
sungwy Nov 27, 2024
9867dd2
test trigger event on fork
sungwy Nov 27, 2024
c4a17b9
use 0.1.0
sungwy Nov 27, 2024
654997b
remove temporary hacks for publishing from fork
sungwy Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/release_python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ jobs:
command: sdist
args: -o dist
- name: Upload sdist
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
name: wheels-sdist
path: bindings/python/dist

wheels:
Expand Down Expand Up @@ -84,9 +84,9 @@ jobs:
# Workaround ring 0.17 build issue
CFLAGS_aarch64_unknown_linux_gnu: "-D__ARM_ARCH=8"
- name: Upload wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
name: wheels-${{ matrix.os }}
path: bindings/python/dist

pypi-publish:
Expand All @@ -105,9 +105,10 @@ jobs:

steps:
- name: Download all the dists
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: wheels
name: wheels-*
merge-multiple: true
path: bindings/python/dist
- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
Expand All @@ -132,7 +133,7 @@ jobs:

steps:
- name: Download all the dists
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: wheels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also be changed to

        name: wheels-*
        merge-multiple: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

path: bindings/python/dist
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

[package]
name = "pyiceberg_core_rust"
version = "0.0.1"
version = "0.1.0"
edition = "2021"
homepage = "https://rust.iceberg.apache.org"
rust-version = "1.77.1"
Expand Down
Loading