Build: Bump Errorprone to 5.64.0

api/src/main/java/org/apache/iceberg/expressions/BoundReference.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.expressions;
 
+import java.util.Locale;
 import org.apache.iceberg.Accessor;
 import org.apache.iceberg.StructLike;
 import org.apache.iceberg.types.Type;
@@ -82,6 +83,7 @@ public Accessor<StructLike> accessor() {
 
   @Override
   public String toString() {
-    return String.format("ref(id=%d, accessor-type=%s)", field.fieldId(), accessor.type());
+    return String.format(
+        Locale.ROOT, "ref(id=%d, accessor-type=%s)", field.fieldId(), accessor.type());
   }
 }

api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java

@@ -23,6 +23,7 @@
 import java.time.ZoneOffset;
 import java.time.temporal.ChronoUnit;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Function;
@@ -493,8 +494,10 @@ private static List<String> abbreviateValues(List<String> sanitizedValues) {
         abbreviatedList.addAll(distinctValues);
         abbreviatedList.add(
             String.format(
+                Locale.ROOT,
                 "... (%d values hidden, %d in total)",
-                sanitizedValues.size() - distinctValues.size(), sanitizedValues.size()));
+                sanitizedValues.size() - distinctValues.size(),
+                sanitizedValues.size()));
         return abbreviatedList;
       }
     }
@@ -615,7 +618,7 @@ private static String sanitizeString(CharSequence value, long now, int today) {
 
   private static String sanitizeSimpleString(CharSequence value) {
     // hash the value and return the hash as hex
-    return String.format("(hash-%08x)", HASH_FUNC.apply(value));
+    return String.format(Locale.ROOT, "(hash-%08x)", HASH_FUNC.apply(value));
   }
 
   private static PartitionSpec identitySpec(Schema schema, int... ids) {

api/src/main/java/org/apache/iceberg/io/BulkDeletionFailureException.java

@@ -18,11 +18,13 @@
  */
 package org.apache.iceberg.io;
 
+import java.util.Locale;
+
 public class BulkDeletionFailureException extends RuntimeException {
   private final int numberFailedObjects;
 
   public BulkDeletionFailureException(int numberFailedObjects) {
-    super(String.format("Failed to delete %d files", numberFailedObjects));
+    super(String.format(Locale.ROOT, "Failed to delete %d files", numberFailedObjects));
     this.numberFailedObjects = numberFailedObjects;
   }
 

api/src/main/java/org/apache/iceberg/transforms/TransformUtil.java

@@ -26,6 +26,7 @@
 import java.time.ZoneOffset;
 import java.time.temporal.ChronoUnit;
 import java.util.Base64;
+import java.util.Locale;
 
 class TransformUtil {
 
@@ -35,19 +36,25 @@ private TransformUtil() {}
   private static final int EPOCH_YEAR = EPOCH.getYear();
 
   static String humanYear(int yearOrdinal) {
-    return String.format("%04d", EPOCH_YEAR + yearOrdinal);
+    return String.format(Locale.ROOT, "%04d", EPOCH_YEAR + yearOrdinal);
   }
 
   static String humanMonth(int monthOrdinal) {
     return String.format(
+        Locale.ROOT,
         "%04d-%02d",
-        EPOCH_YEAR + Math.floorDiv(monthOrdinal, 12), 1 + Math.floorMod(monthOrdinal, 12));
+        EPOCH_YEAR + Math.floorDiv(monthOrdinal, 12),
+        1 + Math.floorMod(monthOrdinal, 12));
   }
 
   static String humanDay(int dayOrdinal) {
     OffsetDateTime day = EPOCH.plusDays(dayOrdinal);
     return String.format(
-        "%04d-%02d-%02d", day.getYear(), day.getMonth().getValue(), day.getDayOfMonth());
+        Locale.ROOT,
+        "%04d-%02d-%02d",
+        day.getYear(),
+        day.getMonth().getValue(),
+        day.getDayOfMonth());
   }
 
   static String humanTime(Long microsFromMidnight) {
@@ -65,8 +72,12 @@ static String humanTimestampWithoutZone(Long timestampMicros) {
   static String humanHour(int hourOrdinal) {
     OffsetDateTime time = EPOCH.plusHours(hourOrdinal);
     return String.format(
+        Locale.ROOT,
         "%04d-%02d-%02d-%02d",
-        time.getYear(), time.getMonth().getValue(), time.getDayOfMonth(), time.getHour());
+        time.getYear(),
+        time.getMonth().getValue(),
+        time.getDayOfMonth(),
+        time.getHour());
   }
 
   static String base64encode(ByteBuffer buffer) {

api/src/main/java/org/apache/iceberg/types/Types.java

@@ -317,7 +317,7 @@ public TypeID typeId() {
 
     @Override
     public String toString() {
-      return String.format("fixed[%d]", length);
+      return String.format(Locale.ROOT, "fixed[%d]", length);
     }
 
     @Override
@@ -388,7 +388,7 @@ public TypeID typeId() {
 
     @Override
     public String toString() {
-      return String.format("decimal(%d, %d)", precision, scale);
+      return String.format(Locale.ROOT, "decimal(%d, %d)", precision, scale);
     }
 
     @Override
@@ -497,7 +497,8 @@ public String doc() {
 
     @Override
     public String toString() {
-      return String.format("%d: %s: %s %s", id, name, isOptional ? "optional" : "required", type)
+      return String.format(
+              Locale.ROOT, "%d: %s: %s %s", id, name, isOptional ? "optional" : "required", type)
           + (doc != null ? " (" + doc + ")" : "");
     }
 
@@ -614,7 +615,7 @@ public Schema asSchema() {
 
     @Override
     public String toString() {
-      return String.format("struct<%s>", FIELD_SEP.join(fields));
+      return String.format(Locale.ROOT, "struct<%s>", FIELD_SEP.join(fields));
     }
 
     @Override
@@ -747,7 +748,7 @@ public Types.ListType asListType() {
 
     @Override
     public String toString() {
-      return String.format("list<%s>", elementField.type());
+      return String.format(Locale.ROOT, "list<%s>", elementField.type());
     }
 
     @Override
@@ -865,7 +866,7 @@ public Types.MapType asMapType() {
 
     @Override
     public String toString() {
-      return String.format("map<%s, %s>", keyField.type(), valueField.type());
+      return String.format(Locale.ROOT, "map<%s, %s>", keyField.type(), valueField.type());
     }
 
     @Override

api/src/main/java/org/apache/iceberg/util/DateTimeUtil.java

@@ -27,6 +27,7 @@
 import java.time.format.DateTimeFormatter;
 import java.time.format.DateTimeFormatterBuilder;
 import java.time.temporal.ChronoUnit;
+import java.util.Locale;
 
 public class DateTimeUtil {
   private DateTimeUtil() {}
@@ -102,7 +103,7 @@ public static String microsToIsoTimestamptz(long micros) {
             .parseCaseInsensitive()
             .append(DateTimeFormatter.ISO_LOCAL_DATE_TIME)
             .appendOffset("+HH:MM:ss", "+00:00")
-            .toFormatter();
+            .toFormatter(Locale.ROOT);
     return localDateTime.atOffset(ZoneOffset.UTC).format(zeroOffsetFormatter);
   }
 

arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/DecimalVectorUtil.java

@@ -19,6 +19,7 @@
 package org.apache.iceberg.arrow.vectorized.parquet;
 
 import java.util.Arrays;
+import java.util.Locale;
 import org.apache.arrow.vector.DecimalVector;
 import org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
 
@@ -62,7 +63,9 @@ static byte[] padBigEndianBytes(byte[] bigEndianBytes, int newLength) {
     }
     throw new IllegalArgumentException(
         String.format(
+            Locale.ROOT,
             "Buffer size of %d is larger than requested size of %d",
-            bigEndianBytes.length, newLength));
+            bigEndianBytes.length,
+            newLength));
   }
 }

core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg;
 
+import java.util.Locale;
 import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicReference;
@@ -327,7 +328,8 @@ private String newTableMetadataFilePath(TableMetadata meta, int newVersion) {
             TableProperties.METADATA_COMPRESSION, TableProperties.METADATA_COMPRESSION_DEFAULT);
     String fileExtension = TableMetadataParser.getFileExtension(codecName);
     return metadataFileLocation(
-        meta, String.format("%05d-%s%s", newVersion, UUID.randomUUID(), fileExtension));
+        meta,
+        String.format(Locale.ROOT, "%05d-%s%s", newVersion, UUID.randomUUID(), fileExtension));
   }
 
   /**

core/src/main/java/org/apache/iceberg/MetricsModes.java

@@ -114,7 +114,7 @@ public int length() {
 
     @Override
     public String toString() {
-      return String.format("truncate(%d)", length);
+      return String.format(Locale.ROOT, "truncate(%d)", length);
     }
 
     @Override

core/src/main/java/org/apache/iceberg/ScanSummary.java

@@ -21,6 +21,7 @@
 import java.io.IOException;
 import java.util.Comparator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.NavigableMap;
 import java.util.Set;
@@ -346,7 +347,7 @@ public void update(K key, Function<V, V> updateFunc) {
       while (map.size() > maxSize) {
         if (throwIfLimited) {
           throw new IllegalStateException(
-              String.format("Too many matching keys: more than %d", maxSize));
+              String.format(Locale.ROOT, "Too many matching keys: more than %d", maxSize));
         }
         this.cut = map.lastKey();
         map.remove(cut);

core/src/main/java/org/apache/iceberg/SnapshotProducer.java

@@ -36,6 +36,7 @@
 import java.io.IOException;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
@@ -497,7 +498,11 @@ protected OutputFile manifestListPath() {
             ops.metadataFileLocation(
                 FileFormat.AVRO.addExtension(
                     String.format(
-                        "snap-%d-%d-%s", snapshotId(), attempt.incrementAndGet(), commitUUID))));
+                        Locale.ROOT,
+                        "snap-%d-%d-%s",
+                        snapshotId(),
+                        attempt.incrementAndGet(),
+                        commitUUID))));
   }
 
   protected EncryptedOutputFile newManifestOutputFile() {

core/src/main/java/org/apache/iceberg/data/avro/IcebergDecoder.java

@@ -23,6 +23,7 @@
 import java.io.UncheckedIOException;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
+import java.util.Locale;
 import java.util.Map;
 import org.apache.avro.AvroRuntimeException;
 import org.apache.avro.Schema;
@@ -138,7 +139,8 @@ public D decode(InputStream stream, D reuse) throws IOException {
 
     if (IcebergEncoder.V1_HEADER[0] != header[0] || IcebergEncoder.V1_HEADER[1] != header[1]) {
       throw new BadHeaderException(
-          String.format("Unrecognized header bytes: 0x%02X 0x%02X", header[0], header[1]));
+          String.format(
+              Locale.ROOT, "Unrecognized header bytes: 0x%02X 0x%02X", header[0], header[1]));
     }
 
     RawDecoder<D> decoder = getDecoder(FP_BUFFER.get().getLong(2));

core/src/main/java/org/apache/iceberg/io/ContentCache.java

@@ -28,6 +28,7 @@
 import java.nio.ByteBuffer;
 import java.time.Duration;
 import java.util.List;
+import java.util.Locale;
 import org.apache.iceberg.exceptions.NotFoundException;
 import org.apache.iceberg.exceptions.ValidationException;
 import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
@@ -253,8 +254,10 @@ private static FileContent download(InputFile input) {
           // IOException and let the caller fallback to non-caching input file.
           throw new IOException(
               String.format(
+                  Locale.ROOT,
                   "Failed to read %d bytes: %d bytes in stream",
-                  fileLength, fileLength - totalBytesToRead));
+                  fileLength,
+                  fileLength - totalBytesToRead));
         } else {
           buffers.add(ByteBuffer.wrap(buf));
         }

core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java

@@ -21,6 +21,7 @@
 import static org.apache.iceberg.TableProperties.DEFAULT_FILE_FORMAT;
 import static org.apache.iceberg.TableProperties.DEFAULT_FILE_FORMAT_DEFAULT;
 
+import java.util.Locale;
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Supplier;
@@ -92,6 +93,7 @@ public static Builder builderFor(Table table, int partitionId, long taskId) {
   private String generateFilename() {
     return format.addExtension(
         String.format(
+            Locale.ROOT,
             "%05d-%d-%s-%05d%s",
             partitionId,
             taskId,

core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java

@@ -31,6 +31,7 @@
 import java.util.AbstractMap;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
 import java.util.function.Consumer;
@@ -798,7 +799,11 @@ private boolean insertProperties(Namespace namespace, Map<String, String> proper
     }
 
     throw new IllegalStateException(
-        String.format("Failed to insert: %d of %d succeeded", insertedRecords, properties.size()));
+        String.format(
+            Locale.ROOT,
+            "Failed to insert: %d of %d succeeded",
+            insertedRecords,
+            properties.size()));
   }
 
   private boolean updateProperties(Namespace namespace, Map<String, String> properties) {
@@ -818,7 +823,11 @@ private boolean updateProperties(Namespace namespace, Map<String, String> proper
     }
 
     throw new IllegalStateException(
-        String.format("Failed to update: %d of %d succeeded", updatedRecords, properties.size()));
+        String.format(
+            Locale.ROOT,
+            "Failed to update: %d of %d succeeded",
+            updatedRecords,
+            properties.size()));
   }
 
   private boolean deleteProperties(Namespace namespace, Set<String> properties) {

core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java

@@ -18,6 +18,7 @@
  */
 package org.apache.iceberg.view;
 
+import java.util.Locale;
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Function;
@@ -157,7 +158,8 @@ private String newMetadataFilePath(ViewMetadata metadata, int newVersion) {
                 ViewProperties.METADATA_COMPRESSION, ViewProperties.METADATA_COMPRESSION_DEFAULT);
     String fileExtension = TableMetadataParser.getFileExtension(codecName);
     return metadataFileLocation(
-        metadata, String.format("%05d-%s%s", newVersion, UUID.randomUUID(), fileExtension));
+        metadata,
+        String.format(Locale.ROOT, "%05d-%s%s", newVersion, UUID.randomUUID(), fileExtension));
   }
 
   private String metadataFileLocation(ViewMetadata metadata, String filename) {