Core: Reimplement CharSequenceMap to obey Map contract #11308
Conversation
findepi
force-pushed
the
findepi/reimplement-charsequencemap-to-obey-map-contract-0cfe9a
branch
2 times, most recently
from
1073832 to
74279c3
Compare
|
A probably even better fix would be to use |
The previous `CharSequenceMap` implementation did not follow general `Map` contract. For example, `Map.keySet()` should be a live view of the keys in the map, but it was a copy. This commit reimplements the class so that it obeys the map contract, while maintaining the fundamental objective of the class, which is to compare `CharSequence` keys by the value of char sequences they describe.
findepi
force-pushed
the
findepi/reimplement-charsequencemap-to-obey-map-contract-0cfe9a
branch
from
74279c3 to
cf74397
Compare
|
draft - let me explore one more possible approach |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
findepi
deleted the
findepi/reimplement-charsequencemap-to-obey-map-contract-0cfe9a
branch
|
Follow-up: #11704 |
The previous
CharSequenceMapimplementation did not follow generalMapcontract. For example,Map.keySet()should be a live view of the keys in the map, but it was a copy. This commit reimplements the class so that it obeys the map contract, while maintaining the fundamental objective of the class, which is to compareCharSequencekeys by the value of char sequences they describe.