Hadoop: Log where the missing metadata file is located #11643
Conversation
| .isInstanceOf(ValidationException.class) | ||
| .hasMessage( | ||
| "Metadata file for version 3 is missing under " | ||
| + (new Path(tableLocation, "metadata"))); |
There was a problem hiding this comment.
isn't this already defined with the metadataDir variable?
There was a problem hiding this comment.
metadataDir is of type File, whose toString result is different from that of Path
There was a problem hiding this comment.
what about metadataDir.toPath().toString()?
There was a problem hiding this comment.
toPath doesn't change the output.
There was a problem hiding this comment.
I'm not sure what exactly you mean by output here. I'm guessing you don't have a file URI and are therefore missing the file: prefix. In that case you could still replace this with metadataDir.toURI().
I'm ok either way, but I'd at least remove the outer () to have new Path(tableLocation, "metadata")
There was a problem hiding this comment.
Updated. metadataDir.toURI() will have a trailing /
|
@nastra any more comments? |
manuzhang
force-pushed
the
log_missing_hadoop_meta
branch
from
eb017a4 to
047fc2b
Compare
Currently, in
HadoopTableOperationswhen the metadata file is missing, we can't know where it's located. This PR adds metadata location to the exception message. Besides, a UT is added for metedata file missing.cc @pvary