Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core, Spark3.5: Fix tests failure due to timeout #11654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manuzhang
Copy link
Contributor

@manuzhang manuzhang commented Nov 26, 2024

This PR attempts to fix following tests failure due to timeout.

#11047
#11066
#11651

@manuzhang manuzhang force-pushed the fix-tests-timeout branch 2 times, most recently from a43d09b to 6f8fb28 Compare November 27, 2024 04:02
@manuzhang manuzhang closed this Nov 27, 2024
@manuzhang manuzhang reopened this Nov 27, 2024
@manuzhang manuzhang force-pushed the fix-tests-timeout branch 2 times, most recently from daf014a to 45e1cd6 Compare December 10, 2024 10:10
@manuzhang
Copy link
Contributor Author

@nastra Please take another look, thanks!

@manuzhang manuzhang closed this Dec 12, 2024
@manuzhang manuzhang reopened this Dec 12, 2024
@manuzhang manuzhang requested a review from nastra December 17, 2024 04:51
@manuzhang manuzhang force-pushed the fix-tests-timeout branch 2 times, most recently from 7961140 to 55f635a Compare December 17, 2024 13:51
@nastra
Copy link
Contributor

nastra commented Dec 17, 2024

@RussellSpitzer or @amogh-jahagirdar can any of you also take a look at this please?

@@ -1609,8 +1611,14 @@ public synchronized void testMergeWithSnapshotIsolation()
createOrReplaceView("source", Collections.singletonList(1), Encoders.INT());

sql(
"ALTER TABLE %s SET TBLPROPERTIES('%s' '%s')",
tableName, MERGE_ISOLATION_LEVEL, "snapshot");
"ALTER TABLE %s SET TBLPROPERTIES('%s', '%s', '%s', '%s', '%s', '%s')",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've got too many commas here. I believe this should be ('%s' '%s', '%s' '%s', '%s' '%s') and same for the other Spark test

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand right, to address flakiness of these tests that are timing out, we're reducing a lot of commit properties (like the max retry and the min retry wait), that way we just fail fast? Typically these should not exceed these values and any tests which do, would just end up failing fast.

Do we have any indication on what could be the root cause for the commits in these tests taking so long?

To be clear, I'm open to giving the fix in this PR a try but I think we should be a bit cautious that we're not introducing flakiness the other way where another set of tests end up failing more frequently due to not waiting enough for example.

@nastra
Copy link
Contributor

nastra commented Dec 17, 2024

@amogh-jahagirdar from what I saw in some local debugging is that these specific tests typically took quite a long time due to exponential retries and eventually timed out, hence this is lowering the min/max wait times for these retries in these 3 particular tests. Other tests shouldn't be affected by this

@amogh-jahagirdar
Copy link
Contributor

Sounds good,

these specific tests typically took quite a long time due to exponential retries and eventually timed out

Yeah this was the part I was trying to unpack was why are these particular tests retrying a lot? Like I said though, that may be difficult to reason about and we may just want to tune these properties in the interim, so all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants