Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump Parquet to 1.15.0 #11656

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Build: Bump Parquet to 1.15.0 #11656

merged 2 commits into from
Dec 4, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Nov 26, 2024

For the full changelog, please check the pre-release:

https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.0-rc1

@github-actions github-actions bot added the build label Nov 26, 2024
@jbonofre
Copy link
Member

@Fokko it seems that jackson is shaded two times with Parquet 1.15. Do you want me to investigate ?

@jbonofre jbonofre self-requested a review November 26, 2024 15:11
@Fokko
Copy link
Contributor Author

Fokko commented Nov 26, 2024

@jbonofre It looks like the palantir baseline plugin doesn't know how to handle Java 22 multi-source packages. Let me take a look first.

@Fokko
Copy link
Contributor Author

Fokko commented Nov 26, 2024

Yes, looks like we need to drop JDK 11 first before we can upgrade to the newer baseline version that correctly knows how to handle the JDK22 shaded files: https://github.com/palantir/gradle-baseline/releases/tag/6.0.0

@github-actions github-actions bot added the INFRA label Nov 26, 2024
@Fokko
Copy link
Contributor Author

Fokko commented Nov 26, 2024

@jbonofre is right, it was not correctly shaded: apache/parquet-java#3081

@Fokko Fokko requested a review from nastra December 4, 2024 08:48
@Fokko
Copy link
Contributor Author

Fokko commented Dec 4, 2024

It already landed in Spark: apache/spark#48970

build.gradle Outdated Show resolved Hide resolved
@nastra nastra changed the title Parquet: Bump to Apache Parquet 1.15.0 Build: Bump Parquet to 1.15.0 Dec 4, 2024
@nastra nastra merged commit c7cef9b into apache:main Dec 4, 2024
49 checks passed
@Fokko Fokko deleted the fd-bump-parquet branch December 4, 2024 11:12
nastra pushed a commit to nastra/iceberg that referenced this pull request Dec 9, 2024
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants