Core: Merge conflicting deletion vectors #11693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
commented
Dec 3, 2024
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Dec 3, 2024
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
commented
Dec 3, 2024
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
merge-conflicting-dvs
branch
from
558bee2 to
fb07a75
Compare
amogh-jahagirdar
force-pushed
the
merge-conflicting-dvs
branch
from
fb07a75 to
a8c5a59
Compare
| * @param spec the data file partition spec | ||
| * @param partition the data file partition | ||
| */ | ||
| default void delete( |
There was a problem hiding this comment.
We could also make this interface take in a List positions (kind of like a batch delete API on the writer) but it felt more natural to just pass in the index imo, cc @aokolnychyi @nastra thoughts?
Comment on lines
+94
to
+98
| public static Builder builderFor( | ||
| TableOperations ops, PartitionSpec spec, FileFormat format, int partitionId, long taskId) { | ||
| return new Builder(ops, spec, format, partitionId, taskId); | ||
| } | ||
|
|
There was a problem hiding this comment.
Needed a way to create an output file factory from table operations since that's all that exists in MergingSnapshotProducer, this is public so we need to be careful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to merge conflicting deletion vectors for a given data file instead of failing the commit. In parallel, every conflicting DV will be merged with the committed DV, and a new Puffin with the merged DV will be output per datafile which had conflicting DVs.
This PR also takes care of any tables that wrote multiple DVs for a given data file (which is not spec compliant) by opportunistically merging those as well