Spark 3.5: Add ignore-invalid-options to RewriteDataFilesSparkAction and RewritePositionDeleteFilesSparkAction #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and RewritePositionDeleteFilesSparkAction
huaxingao
reviewed
Dec 11, 2024
| basicRewrite(table) | ||
| .option("ignore-invalid-options", "true") | ||
| .option("foobarity", "-5") | ||
| .execute(); |
There was a problem hiding this comment.
Should we also test the default behavior of ignore-invalid-options, similar to what you did in TestRewritePositionDeleteFilesAction.testIgnoreInvalidOptions?
There was a problem hiding this comment.
It's covered by testInvalidOptions() above.
|
@ajantha-bhat @RussellSpitzer @nastra Please help review whether this is a valid request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option
ignore-invalid-optionsto RewriteDataFilesSparkAction and RewritePositionDeleteFilesSparkAction.It can be useful when we canary-release a new Iceberg version with new options for the above two actions.