Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive: Add Hive 4 support and remove Hive runtime #11750

Closed
wants to merge 3 commits into from

Conversation

manuzhang
Copy link
Collaborator

@manuzhang manuzhang commented Dec 11, 2024

As per consensus on https://lists.apache.org/thread/jfcqfw9vhq4j7h0kwnlf338jgyzcq8s4, this PR

  1. Upgrade hive connectors to Hive 4.0.1
  2. Remove hive 3 runtime
  3. Remove hive 2 from iceberg-mr

@github-actions github-actions bot added the INFRA label Dec 11, 2024
@manuzhang manuzhang marked this pull request as ready for review December 12, 2024 01:15
@manuzhang manuzhang mentioned this pull request Dec 12, 2024
@pvary
Copy link
Contributor

pvary commented Dec 12, 2024

Will check next week if it is not merged till then

Copy link
Contributor

@okumin okumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manuzhang manuzhang force-pushed the support-hive4 branch 2 times, most recently from 0adcdef to 44cd3cb Compare December 13, 2024 03:31
@github-actions github-actions bot removed the MR label Dec 13, 2024
@manuzhang manuzhang marked this pull request as draft December 13, 2024 04:30
@github-actions github-actions bot added the MR label Dec 13, 2024
@manuzhang manuzhang changed the title Hive: Add Hive 4 support and remove Hive 3 Hive: Add Hive 4 support and remove Hive runtime Dec 13, 2024
@manuzhang
Copy link
Collaborator Author

manuzhang commented Dec 18, 2024

I've created a separate PR #11801 to remove Hive runtime since we can't upgrade hive-metastore dependency until Spark 4.

@pvary
Copy link
Contributor

pvary commented Jan 2, 2025

What is the root cause behind the strict version requirements of older Spark versions? The 4.0.0 HMS supposed to be compatible with older clients

@manuzhang
Copy link
Collaborator Author

It's due to API changes like this and this.

@pvary
Copy link
Contributor

pvary commented Jan 3, 2025

It's due to API changes like this and this.

Could we just exclude the Hive dependency from the iceberg-hive-metastore in the old Spark module and rely on Spark to include the old Hive dependency? This would not work if we were using new Hive 4 features in the code, but it is not the case, so it seems OK for the Hive perspective.

@manuzhang
Copy link
Collaborator Author

Spark (and other modules) also depend on TestHiveMetastore from test modules of iceberg-hive-metastore. We cannot use old Hive dependency from Spark to run this class due to API changes.

@pvary
Copy link
Contributor

pvary commented Jan 6, 2025

Spark (and other modules) also depend on TestHiveMetastore from test modules of iceberg-hive-metastore. We cannot use old Hive dependency from Spark to run this class due to API changes.

TestHiveMetastore is a test only code. If we use a shaded version for testing and using our own Hive version for it, then it should be fine.

For the production code:
I would argue that if there are compatibility issues with the HMS Client (I don't know about any of them ATM), then as we use our own shaded avro version to write the manifest files, we probably HiveCatalog should use its own shaded HMSClient too.

Copy link

github-actions bot commented Feb 6, 2025

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 6, 2025
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Feb 14, 2025
@deniskuzZ
Copy link
Member

hi @manuzhang, do you plan to continue with the PR?

@manuzhang
Copy link
Collaborator Author

@deniskuzZ yes, I'm planning to work on Hive 4 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants