-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hive: Add Hive 4 support and remove Hive runtime #11750
Conversation
2d0c98f
to
0c20745
Compare
Will check next week if it is not merged till then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0c20745
to
fa5595c
Compare
0adcdef
to
44cd3cb
Compare
44cd3cb
to
e162ad5
Compare
e162ad5
to
e567e8d
Compare
3eaf1c3
to
7f9a9c4
Compare
7f9a9c4
to
47ca107
Compare
47ca107
to
7212627
Compare
What is the root cause behind the strict version requirements of older Spark versions? The 4.0.0 HMS supposed to be compatible with older clients |
Could we just exclude the Hive dependency from the iceberg-hive-metastore in the old Spark module and rely on Spark to include the old Hive dependency? This would not work if we were using new Hive 4 features in the code, but it is not the case, so it seems OK for the Hive perspective. |
Spark (and other modules) also depend on |
For the production code: |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
hi @manuzhang, do you plan to continue with the PR? |
@deniskuzZ yes, I'm planning to work on Hive 4 support. |
As per consensus on https://lists.apache.org/thread/jfcqfw9vhq4j7h0kwnlf338jgyzcq8s4, this PR